Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browse page does not show all datasets #62

Closed
lukasjelonek opened this issue Nov 6, 2023 · 2 comments
Closed

Browse page does not show all datasets #62

lukasjelonek opened this issue Nov 6, 2023 · 2 comments
Labels
bug Something isn't working Priority low lowest priority

Comments

@lukasjelonek
Copy link
Member

The browse page only shows 640,090 datasets. A search with an empty query shows 661,405 datasets.

@lukasjelonek lukasjelonek added bug Something isn't working Priority medium default priority, handle after high priority issues are done labels Nov 6, 2023
@lukasjelonek
Copy link
Member Author

It seems as if the browse page always sends a full query with the values from the filter block. Increasing the values for max contigs, max genome size and max contamination increases the found datasets, but it does not reach the 661,405 datasets from the search.

I see two ways to handle this:

  1. Obtain the min/max values for each field and see if all datasets are retrieved
  2. Build the search incrementally when the user enters some values, e.g.
  • when he does not enter anything, an empty query is send,
  • when he modifies the gc range, only the gc query is send
  • when he modifies multiple fields, only these fields are part of the query

@lukasjelonek lukasjelonek added Unprioritized New issue that has no priority yet Priority low lowest priority and removed Priority medium default priority, handle after high priority issues are done Unprioritized New issue that has no priority yet labels Nov 6, 2023
@crsct
Copy link
Collaborator

crsct commented Dec 19, 2023

this should be fixed when #74 closes, if it doesnt, please let me know.

@crsct crsct closed this as completed Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority low lowest priority
Projects
None yet
Development

No branches or pull requests

2 participants