Skip to content

Issue #2950 [LanguageNavigation v2] Accessibility and usability improvments #2951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Issue #2950 [LanguageNavigation v2] Accessibility and usability improvments #2951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97aedc9
Fix language v2
Jun 13, 2025
98f355c
Add the disclosure pattern to Language navigation
Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions bundles/core/src/main/java/com/adobe/cq/wcm/core/components/models/LanguageNavigation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,13 @@ default String getAccessibilityLabel() {
return null;
}

/**
* Indicates whether the language navigation use the disclosure pattern.
*
* @return true if the language navigation use the disclosure pattern; false otherwise
*/
default boolean isDropdown() {
return false;
}

}
9 changes: 9 additions & 0 deletions ...apps/core/wcm/components/languagenavigation/v2/languagenavigation/_cq_dialog/.content.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,15 @@
fieldLabel="ID"
name="./id"
validation="html-unique-id-validator"/>
<dropdown
jcr:primaryType="nt:unstructured"
sling:resourceType="granite/ui/components/coral/foundation/form/checkbox"
checked="${not empty cqDesign.isDropdown ? cqDesign.isDropdown : false}"
fieldDescription="The language structure use the dislosure pattern."
forceIgnoreFreshness="true"
name="./isDropdown"
uncheckedValue="false"
value="{Boolean}true"/>
</items>
</column>
</items>
Expand Down
4 changes: 2 additions & 2 deletions ...ent/jcr_root/apps/core/wcm/components/languagenavigation/v2/languagenavigation/group.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
~ See the License for the specific language governing permissions and
~ limitations under the License.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~*/-->
<template data-sly-template.group="${@ items='The language navigation items for the current level'}" data-sly-use.itemTemplate="item.html">
<ul class="cmp-languagenavigation__group" data-sly-list.item="${items}">
<template data-sly-template.group="${@ items='The language navigation items for the current level', label='The language navigation label', id='The language navigation id'}" data-sly-use.itemTemplate="item.html">
<ul class="cmp-languagenavigation__group" data-sly-list.item="${items}" aria-label="${label} id="${id}">
<sly data-sly-call="${itemTemplate.item @ item = item}"></sly>
</ul>
</template>
5 changes: 4 additions & 1 deletion ...r_root/apps/core/wcm/components/languagenavigation/v2/languagenavigation/itemContent.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,8 @@
data-cmp-clickable="${item.data ? true : false}"
class="cmp-languagenavigation__item-link"
data-sly-attribute="${item.link.htmlAttributes}"
hreflang="${item.language}" lang="${item.language}" rel="alternate">${item.title}</a>
hreflang="${item.language}" lang="${item.language}" rel="alternate"
title="${item.language} - ${item.title}">
<span>${item.language}</span>
<span>${item.title}</span>
</template>
25 changes: 17 additions & 8 deletions ...apps/core/wcm/components/languagenavigation/v2/languagenavigation/languagenavigation.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,24 @@
~ See the License for the specific language governing permissions and
~ limitations under the License.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~*/-->
<nav data-sly-use.languageNavigation="com.adobe.cq.wcm.core.components.models.LanguageNavigation"
<div data-sly-use.languageNavigation="com.adobe.cq.wcm.core.components.models.LanguageNavigation"
data-sly-use.commonsTemplates="core/wcm/components/commons/v1/templates.html"
data-sly-use.groupTemplate="group.html"
data-sly-call="${groupTemplate.group @ items=languageNavigation.items}"
data-sly-test.hasContent="${languageNavigation.items.size > 0}"
data-sly-test.hasContent="${languageNavigation.items.size > 1}"
data-cmp-data-layer="${languageNavigation.data.json}"
id="${languageNavigation.id}"
class="cmp-languagenavigation"
aria-label="${languageNavigation.accessibilityLabel}"
role="navigation">
</nav>
class="cmp-languagenavigation">
<sly data-sly-list.item="${languageNavigation.items}"
data-sly-test="${languageNavigation.isDropdown}">
<button data-sly-test="${item.active}"
class="cmp-languagenavigation-button"
type="button"
aria-controls="${languageNavigation.id}"
aria-label="${languageNavigation.accessibilityLabel} : ${item.language} – ${item.title}"
aria-expanded="false">
<span>${item.language}</span>
<span>${item.title}</span>
</button>
</sly>
<sly data-sly-call="${groupTemplate.group @ items=languageNavigation.items, label=languageNavigation.accessibilityLabel, id=languageNavigation.id}"></sly>
</div>
<sly data-sly-call="${commonsTemplates.placeholder @ isEmpty = !hasContent, classAppend='cmp-languagenavigation'}"></sly>
Loading