Skip to content

Conversation

renow-luxembourg
Copy link
Contributor

Q                       A
Fixed Issues? Fixes #2950
Patch: Bug Fix?
Minor: New Feature? Yes
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

Changes description :

  • Replace the nav container by a div and move the aria-label attribute to the ul element
  • Automatically hide the component if the website is in only 1 language
  • Display both the ISO code and the full language name. One of them can be visually hidden using some CSS similar to the "sr-only" class.
  • Add a parameter in the cq_dialog to display the language as a dropdown list using the disclosure design pattern

If it's easier, I can split this pull request into several.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[LanguageNavigation v2] Remove nav element + improvement

1 participant