Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SITES-22335] Fix smart crop test #2790

Merged
merged 5 commits into from
Jun 27, 2024
Merged

[SITES-22335] Fix smart crop test #2790

merged 5 commits into from
Jun 27, 2024

Conversation

alexandru-stancioiu
Copy link
Contributor

@alexandru-stancioiu alexandru-stancioiu commented Jun 19, 2024

Q                       A
Fixed Issues? SITES-9113, ASSETS-33747
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

Changelog:

  • Fix smart crop test
  • Fix alt text error message when seeded value is inexistent
  • For remote assets, remove inherit alt text checkbox
  • For remote assets, do not try to get and update seeded value

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.21%. Comparing base (90a8cfa) to head (6514f5b).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2790   +/-   ##
=========================================
  Coverage     87.21%   87.21%           
  Complexity     2687     2687           
=========================================
  Files           235      235           
  Lines          7170     7170           
  Branches       1096     1096           
=========================================
  Hits           6253     6253           
  Misses          363      363           
  Partials        554      554           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jun 27, 2024

@alexandru-stancioiu alexandru-stancioiu merged commit b5e6a56 into main Jun 27, 2024
14 checks passed
@alexandru-stancioiu alexandru-stancioiu deleted the sites_22335_2 branch June 27, 2024 10:56
@YahorC YahorC added this to the 2.26.0 milestone Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants