Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SITES-22335] Remove validation of ImageFromPageImage for image v2 #2811

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

alexandru-stancioiu
Copy link
Contributor

@alexandru-stancioiu alexandru-stancioiu commented Jul 9, 2024

Previous PR #2790 introduced a regression because it assumed ImageFromPageImage selection exists on both Image V2 and V3, but it is only present on Image V3

Q                       A
Fixed Issues? cannot read property of null
Patch: Bug Fix? Yes
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes, fixes test testSetAssetWithoutDescription
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.21%. Comparing base (f7dc418) to head (c704997).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2811   +/-   ##
=========================================
  Coverage     87.21%   87.21%           
  Complexity     2690     2690           
=========================================
  Files           235      235           
  Lines          7173     7173           
  Branches       1096     1096           
=========================================
  Hits           6256     6256           
  Misses          363      363           
  Partials        554      554           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jul 19, 2024

@alexandru-stancioiu alexandru-stancioiu merged commit 9b6d2c1 into main Jul 19, 2024
14 checks passed
@alexandru-stancioiu alexandru-stancioiu deleted the sites_22335_fix_image_v2 branch July 19, 2024 12:58
@YahorC YahorC added this to the 2.26.0 milestone Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants