-
Notifications
You must be signed in to change notification settings - Fork 58
FORMS-19758: Addition of fragmentPath to the CRISPR JSON in Author View #1593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vjystva
wants to merge
6
commits into
dev
Choose a base branch
from
fragmentPathCrispr
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9f32f9a
Added fragment path in Crispr json for Author view
e4a78b5
RTC Adding Default specVersionfor formcontainerv2 test
vjystva 1f43c8b
RTC updating test baseline
vjystva 39eedc7
updated baseline
vjystva be1829d
updating baseline
vjystva 7d9ba0f
Added test cases and addressed review comments
vjystva File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
bundles/af-core/src/test/resources/form/fragment/exporter-fragment-with-fragment-path.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
{ | ||
"id": "fragment-c83f64bf1d", | ||
"fieldType": "panel", | ||
"name": "fragment-123", | ||
"type": "object", | ||
"repeatable": true, | ||
"minOccur": 0, | ||
"maxOccur": 4, | ||
"fragmentPath": "/content/affragment", | ||
"properties": { | ||
"customProp": "customPropValue", | ||
"fd:dor": { | ||
"dorExclusion": false, | ||
"dorExcludeTitle": false, | ||
"dorExcludeDescription": false | ||
}, | ||
"fd:path": "/content/fragment-with-fragment-path", | ||
"fd:fragment": true, | ||
"fd:viewType": "fragment" | ||
}, | ||
"label": { | ||
"value": "Fragment" | ||
}, | ||
"events": { | ||
"custom:setProperty": [ | ||
"$event.payload" | ||
] | ||
}, | ||
":itemsOrder": [ | ||
"textinput" | ||
], | ||
":items": { | ||
"textinput": { | ||
"id": "textinput-233cc688ba", | ||
"fieldType": "text-input", | ||
"name": "fragmenttextinput", | ||
"type": "string", | ||
"label": { | ||
"value": "Text Input" | ||
}, | ||
"properties": { | ||
"fd:dor": { | ||
"dorExclusion": false | ||
}, | ||
"fd:path": "/content/affragment/jcr:content/guideContainer/textinput" | ||
}, | ||
"events": { | ||
"custom:setProperty": [ | ||
"$event.payload" | ||
] | ||
}, | ||
":type": "core/fd/components/form/textinput/v1/textinput" | ||
} | ||
}, | ||
":type": "core/fd/components/form/fragment/v1/fragment" | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
...af-core/src/test/resources/schema/0.15.2/adaptive-form-aem-allowed-components.schema.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
{ | ||
"$id": "classpath:/schema/0.15.2/adaptive-form-aem-allowed-components.schema.json", | ||
"$schema": "http://json-schema.org/draft-07/schema#", | ||
"type": "object", | ||
"title": "Allowed Components object for the current panel.", | ||
"description": "This is applicable only if the panel's layout is grid system. This property is useful if needs to show list of allowed components in the client while authoring the panel.", | ||
"properties": { | ||
"components": { | ||
"type": "array", | ||
"title": "List of simple objects representing all Allowed Components for the given panel" | ||
}, | ||
"applicable": { | ||
"type": "boolean", | ||
"title": "Is the given panel contained by a page, with authored template structure and is the given panel set as editable (unlocked)", | ||
"description": "true if the template has structure support and the panel is editable, false otherwise" | ||
} | ||
} | ||
} |
52 changes: 52 additions & 0 deletions
52
...src/test/resources/schema/0.15.2/adaptive-form-aem-responsive-grid-properties.schema.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
{ | ||
"$id": "classpath:/schema/0.15.2/adaptive-form-aem-responsive-grid-properties.schema.json", | ||
"$schema": "http://json-schema.org/draft-07/schema#", | ||
"type": "object", | ||
"properties": { | ||
"allowedComponents": { | ||
"$ref": "./adaptive-form-aem-allowed-components.schema.json" | ||
}, | ||
"appliedCssClassNames": { | ||
"title": "CSS classes delimited using a SPACE character", | ||
"description": "Describes the style system information associated with the current form element", | ||
"type": "string", | ||
"examples": [ | ||
{ | ||
"appliedCssClassNames": "outlined red-border" | ||
} | ||
] | ||
}, | ||
"gridClassNames": { | ||
"title": "The CSS class names to be applied to the current panel delimited using a SPACE character", | ||
"description": "This is applicable only if the panel's layout is grid system.", | ||
"type": "string", | ||
"examples": [ | ||
{ | ||
"gridClassNames": "aem-Grid aem-Grid--12 aem-Grid--default--12" | ||
} | ||
] | ||
}, | ||
"columnClassNames": { | ||
"title": "The CSS class names associated with each responsive grid column and listed by column name", | ||
"description": "This is applicable only if the panel's layout is grid system.", | ||
"type": "object", | ||
"examples": [ | ||
{ | ||
"columnClassNames": { | ||
"title_v3": "aem-GridColumn aem-GridColumn--default--12" | ||
} | ||
} | ||
] | ||
}, | ||
"columnCount": { | ||
"title": "The number of columns available for direct children in the panel.", | ||
"description": "This is applicable only if the panel's layout is grid system.", | ||
"type": "number", | ||
"examples": [ | ||
{ | ||
"columnCount": 12 | ||
} | ||
] | ||
} | ||
} | ||
} |
44 changes: 44 additions & 0 deletions
44
...-core/src/test/resources/schema/0.15.2/adaptive-form-container-dor-properties.schema.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
{ | ||
"$id": "classpath:/schema/0.15.2/adaptive-form-container-dor-properties.schema.json", | ||
"$schema": "http://json-schema.org/draft-07/schema#", | ||
"type": "object", | ||
"additionalProperties": false, | ||
"properties": { | ||
"dorType": { | ||
"title": "DOR Type", | ||
"description": "Describes the type of Document of Record (DOR)", | ||
"type": "string", | ||
"enum": [ | ||
"generate", | ||
"select" | ||
], | ||
"examples": [ | ||
{ | ||
"dorType": "generate" | ||
} | ||
] | ||
}, | ||
"dorTemplateRef": { | ||
"title": "DOR Template Reference", | ||
"description": "Reference to the template for the Document of Record (DOR).", | ||
"type": "string", | ||
"examples": [ | ||
{ | ||
"dorTemplateRef": "/content/dam/formsanddocuments/acro form conversion.pdf" | ||
} | ||
] | ||
}, | ||
"dorTemplateType": { | ||
"title": "DOR Template Type", | ||
"description": "Type of the template for the Document of Record (DOR).", | ||
"enum": [ | ||
"acroform", | ||
"xfa" | ||
], | ||
"type": "string" | ||
}, | ||
"pageTemplate": { | ||
"$ref": "./print/adaptive-form-page-template-properties.schema.json" | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test case to check the presence of this property in the json ? You can refer existing test case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test case added.