FORMS-19758: Addition of fragmentPath to the CRISPR JSON in Author View #1593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1593 +/- ##
=========================================
Coverage 82.32% 82.32%
Complexity 1000 1000
=========================================
Files 108 108
Lines 2603 2603
Branches 370 370
=========================================
Hits 2143 2143
Misses 272 272
Partials 188 188 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
Accessibility Violations Found
|
devgurjar
reviewed
May 28, 2025
| @@ -8,6 +8,7 @@ | |||
| "fd:enableAutoSave": "true", | |||
| "fd:autoSaveInterval": "2", | |||
| "fd:autoSaveStrategyType": "time", | |||
| "specVersion": "0.14.2", | |||
There was a problem hiding this comment.
this should be changed to latest version 0.15.2
There was a problem hiding this comment.
I have reverted the specVersion. But I has seen test failures so let's connect to figure this out.
| @@ -29,6 +29,7 @@ | |||
| "dorTemplateRef": "xyz", | |||
| "clientLibRef": "abc", | |||
| "customProp": "customPropValue", | |||
| "specVersion": "0.14.2", | |||
There was a problem hiding this comment.
this should be changed to latest version 0.15.2
rismehta
requested changes
Jun 9, 2025
| @@ -80,7 +82,7 @@ private void initFragmentModel() { | |||
| } | |||
| } | |||
|
|
|||
| @JsonIgnore | |||
| @JsonView(Views.Author.class) | |||
There was a problem hiding this comment.
Can we add a test case to check the presence of this property in the json ? You can refer existing test case
github-actions
bot
force-pushed
the
fragmentPathCrispr
branch
from
b43e79d to
7d9ba0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support to include fragmentPath in Crispr json.
More details can be found - https://git.corp.adobe.com/livecycle/af2-docs/issues/222
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: