Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uforead] parse multiple attrs in xmlNode #1720

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Conversation

kaydeearts
Copy link
Collaborator

@kaydeearts kaydeearts commented Oct 24, 2023

This is to fix #1673 #1669

@frankrolf can you review & confirm this fixes the issue? I've attached the new output font and ran the test script:

ufo-advance-height-weight.otf
{'.notdef': (100, 0), 'space': (200, 0), 'A': (400, 47)}

ufo-advance-height-weight.otf.zip

Checklist:

  • I have followed the [Contribution Guidelines](https://github.com/adobe-type
    -tools/afdko/blob/develop/CONTRIBUTING.md)
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@kaydeearts kaydeearts changed the title Kd parse attrs [uforead] parse multiple attrs in xmlNode Oct 24, 2023
Copy link
Collaborator

@skef skef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@kaydeearts kaydeearts merged commit b955b77 into develop Oct 25, 2023
17 checks passed
@kaydeearts kaydeearts deleted the kd-parse-attrs branch October 25, 2023 20:41
@frankrolf
Copy link
Member

Thank you for fixing this! I have no idea to test the PR locally, but I am grateful anyway :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[makeotf] glyph width collapsed to 0 if UFO contains advance height
3 participants