Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uforead] uforead fails to set advance width when height is also defined in the glif file #1669

Closed
punchcutter opened this issue Jul 6, 2023 · 2 comments

Comments

@punchcutter
Copy link
Contributor

In a glif file that has both advance height and width defined like <advance height="1000" width="1000"/> uforead fails to read the width and sets it to 0. If width comes first then it gets read. We need to check for height as well. Right now we can just ignore it because width is more important, but correctly using height is something that can be dealt with later (more info in fonttools/fonttools#2704 about using advance height from UFO to set vmtx/VORG).

if (xmlAttrEqual(attr, "width") || xmlAttrEqual(attr, "advance"))

@hatchzo
Copy link

hatchzo commented Jul 6, 2023

I saw the same problem, when height value comes first, as in <advance height="1000" width="1000"/>, width value is ignored.

@kaydeearts
Copy link
Collaborator

Resolved by #1720.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants