Skip to content

fix(awc): close connections after GO_AWAY local or remote GO_AWAY errors #3790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2025
Merged

fix(awc): close connections after GO_AWAY local or remote GO_AWAY errors #3790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions awc/CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased

- Fix a bug where `GO_AWAY` errors did not stop connections from returning to the pool.

## 3.8.0

- Add `hickory-dns` crate feature (off-by-default).
Expand Down
4 changes: 2 additions & 2 deletions awc/src/client/h2proto.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ where

let res = poll_fn(|cx| io.poll_ready(cx)).await;
if let Err(err) = res {
io.on_release(err.is_io());
io.on_release(err.is_io() || err.is_go_away());
return Err(SendRequestError::from(err));
}

Expand All @@ -121,7 +121,7 @@ where
fut.await.map_err(SendRequestError::from)?
}
Err(err) => {
io.on_release(err.is_io());
io.on_release(err.is_io() || err.is_go_away());
return Err(err.into());
}
};
Expand Down
Loading