fix(awc): close connections after GO_AWAY local or remote GO_AWAY errors #3790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Bug Fix
PR Checklist
Overview
This fix attempts to resolve the issue described here: #3788
Essentially local GO_AWAY errors are generated by
h2when a connection has seen too many local-resets (such as from locally-enforced timeouts).This is a more general fix than seen here: #3678 which resolves a very similar issue with remote-resets also being ignored.
This fix would have a go away - whether generated locally by
h2or remotely - cause the connection to be closed instead of returned to the pool for reuse.Closes #3788
Closes #3678