Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable entity-specific calculation of inspected points + inspected points score #28

Merged
merged 1 commit into from
Jan 9, 2025
Merged

enable entity-specific calculation of inspected points + inspected points score #28

merged 1 commit into from
Jan 9, 2025

Conversation

JohnMcCarroll
Copy link
Collaborator

closes issue #27

@JohnMcCarroll JohnMcCarroll linked an issue Nov 28, 2024 that may be closed by this pull request
Add support for entity-specific calculation of inspected points number and score #27
Closed
@JohnMcCarroll JohnMcCarroll mentioned this pull request Dec 2, 2024
Merged
jamie-cunningham
jamie-cunningham requested changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@jamie-cunningham jamie-cunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add unit tests for these methods using the inspector_entity argument

@JohnMcCarroll
Copy link
Collaborator Author

Add unit tests for these methods using the inspector_entity argument

It looks like there already exist some unit tests to validate the get_num_points_inspected and get_total_weight_inspected methods when the inspector_entity argument is supplied. I ran them locally and they passed.

@jamie-cunningham jamie-cunningham merged commit c3aa3a5 into main Jan 9, 2025
4 checks passed
jamie-cunningham pushed a commit that referenced this pull request Jan 9, 2025
@semantic-release-bot
chore(release): 2.1.4
4eb3d5e 
## [2.1.4](v2.1.3...v2.1.4) (2025-01-09)

### Bug Fixes

* **inspection:** enable entity-specific inspection point attributionfixed agent inspection weight attribution bug and added single agent inspection points attribution ([#28](#28)) ([c3aa3a5](c3aa3a5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamie-cunningham jamie-cunningham jamie-cunningham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for entity-specific calculation of inspected points number and score
2 participants
@JohnMcCarroll @jamie-cunningham