-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command polish #8
Commits on Aug 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b57f25b - Browse repository at this point
Copy the full SHA b57f25bView commit details -
Removes some unnecessary and confusing nesting based around validating command arguments.
Configuration menu - View commit details
-
Copy full SHA for c78ee75 - Browse repository at this point
Copy the full SHA c78ee75View commit details -
Update status command's description
Reflects the commands ability to display status for multiple NPCs.
Configuration menu - View commit details
-
Copy full SHA for 3c1689f - Browse repository at this point
Copy the full SHA 3c1689fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 75a939b - Browse repository at this point
Copy the full SHA 75a939bView commit details -
Improve readability of main loop control flow
Removing continue makes following the flow of control of the main loop more obvious.
Configuration menu - View commit details
-
Copy full SHA for 69c50a4 - Browse repository at this point
Copy the full SHA 69c50a4View commit details -
Use numbers 0 or below to reset NPC rank. Bounds all negative ranks to 0, so all negative values have the same ranking as 0. The distinction between ranked or not could help establish which NPCs are active in the encounter or not.
Configuration menu - View commit details
-
Copy full SHA for 8def0ee - Browse repository at this point
Copy the full SHA 8def0eeView commit details -
Improve NPC class str method readability
This commit makes it more clear what the final output should look like and why.
Configuration menu - View commit details
-
Copy full SHA for a2244f3 - Browse repository at this point
Copy the full SHA a2244f3View commit details -
Code styling on attack and smite commands
Minor stylistic changes in preparation for changing rank command behavior.
Configuration menu - View commit details
-
Copy full SHA for 5ec1ed3 - Browse repository at this point
Copy the full SHA 5ec1ed3View commit details -
Perform error checking on bestiary load
Uses the YAML file format instead of a home grown CSV format. This allows for use of the robust PyYAML parser for loading objects from a file. This commit also performs some basic error checking to keep the program from hard crashing when encountering some kind of syntactical error in the provided YAML file.
Configuration menu - View commit details
-
Copy full SHA for 1452c5a - Browse repository at this point
Copy the full SHA 1452c5aView commit details -
This commit implements the all selector for the add command. This commit also provides better error messages in the case the user provides a non integer for a selector index.
Configuration menu - View commit details
-
Copy full SHA for 3f42638 - Browse repository at this point
Copy the full SHA 3f42638View commit details -
No longer needed after modifying load behavior.
Configuration menu - View commit details
-
Copy full SHA for dcda886 - Browse repository at this point
Copy the full SHA dcda886View commit details -
Gives an indication of load status success automatically.
Configuration menu - View commit details
-
Copy full SHA for b513739 - Browse repository at this point
Copy the full SHA b513739View commit details -
Make command error methods static
This method did not need to differ per instance and did not rely on any class attributes.
Configuration menu - View commit details
-
Copy full SHA for 0a225ff - Browse repository at this point
Copy the full SHA 0a225ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9052398 - Browse repository at this point
Copy the full SHA 9052398View commit details -
This behavior regressed after rewrite of NPC.__str__
Configuration menu - View commit details
-
Copy full SHA for e52a8ef - Browse repository at this point
Copy the full SHA e52a8efView commit details -
Make NPC display and status unique
The NPC.__str__ method used for displaying NPCs in menus is somewhat simplified by hiding NPC base type if the NPC has a nickname. The status command now reveals the NPC base type and note details.
Configuration menu - View commit details
-
Copy full SHA for 9bc78c0 - Browse repository at this point
Copy the full SHA 9bc78c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef7f93a - Browse repository at this point
Copy the full SHA ef7f93aView commit details -
Move rank sorting responsibility to main
Sorts list after every operation meaning ordering can be maintained if other commands cause side effects that change the overall NPC ordering.
Configuration menu - View commit details
-
Copy full SHA for 12308e0 - Browse repository at this point
Copy the full SHA 12308e0View commit details -
Effective rank is set to 0 on death. Rank can be edited after death. Effective rank will be restored on revive.
Configuration menu - View commit details
-
Copy full SHA for 626bc25 - Browse repository at this point
Copy the full SHA 626bc25View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f7bd3a - Browse repository at this point
Copy the full SHA 7f7bd3aView commit details