Command polish #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consistently use double quotes throughout code.
Removes some unnecessary and confusing nesting based around validating command arguments.
Reflects the commands ability to display status for multiple NPCs.
Removing continue makes following the flow of control of the main loop more obvious.
Use numbers 0 or below to reset NPC rank. Bounds all negative ranks to 0, so all negative values have the same ranking as 0. The distinction between ranked or not could help establish which NPCs are active in the encounter or not.
This commit makes it more clear what the final output should look like and why.
Minor stylistic changes in preparation for changing rank command behavior.
Uses the YAML file format instead of a home grown CSV format. This allows for use of the robust PyYAML parser for loading objects from a file. This commit also performs some basic error checking to keep the program from hard crashing when encountering some kind of syntactical error in the provided YAML file.
This commit implements the all selector for the add command. This commit also provides better error messages in the case the user provides a non integer for a selector index.
No longer needed after modifying load behavior.
Gives an indication of load status success automatically.
This method did not need to differ per instance and did not rely on any class attributes.
This behavior regressed after rewrite of NPC.__str__
The NPC.__str__ method used for displaying NPCs in menus is somewhat simplified by hiding NPC base type if the NPC has a nickname. The status command now reveals the NPC base type and note details.
Sorts list after every operation meaning ordering can be maintained if other commands cause side effects that change the overall NPC ordering.
Effective rank is set to 0 on death. Rank can be edited after death. Effective rank will be restored on revive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge improves the following commands: