Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npc type split #10

Merged
merged 11 commits into from
Aug 15, 2023
Merged

Npc type split #10

merged 11 commits into from
Aug 15, 2023

Commits on Aug 8, 2023

  1. Initial implementation of NPC class split

    Motivation behind this class split is to enable different behaviors for NPCs in the bestiary vs those in the encounter.
    
    Most notably bestiary NPCs have some detailed user defined description.
    Yochien committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    32b7b54 View commit details
    Browse the repository at this point in the history
  2. Don't set nickname if not given

    Removes the odd behavior of the nickname copying the name if no nickname was given. Using None makes it more clear that the nickname is missing entirely.
    
    This does make it impossible to remove a nickname once given though.
    Yochien committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    bf63496 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dc3c3ca View commit details
    Browse the repository at this point in the history
  4. Implement combat NPC tests

    Replaces old NPC tests with combat NPC tests.
    
    Still need bestiary NPC tests.
    Yochien committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    35f39a8 View commit details
    Browse the repository at this point in the history
  5. Define property for NPC nickname

    Allows defining the reset and empty behaviors within the class itself.
    Yochien committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    cbe3c47 View commit details
    Browse the repository at this point in the history
  6. Implement BookNPC tests

    Yochien committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    5b94c2c View commit details
    Browse the repository at this point in the history
  7. Implement NPCList tests

    Yochien committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    6eb8dcd View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Implement info all

    With the split between NPC types, info is a much more helpful command so info all is a useful tool.
    Yochien committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    6c147be View commit details
    Browse the repository at this point in the history
  2. Include more flavor text

    Yochien committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    ab907d0 View commit details
    Browse the repository at this point in the history
  3. Perform smite input validation once

    The isValidInt method already checks a whole list of values, so there is no need to loop over them as done before.
    Yochien committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    bdee2fd View commit details
    Browse the repository at this point in the history
  4. Implement info multiselect

    Removes duplicates and sort the selection. Ideally would only remove the duplicates.
    Yochien committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    1fb4136 View commit details
    Browse the repository at this point in the history