-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Npc type split #10
Merged
Npc type split #10
Commits on Aug 8, 2023
-
Initial implementation of NPC class split
Motivation behind this class split is to enable different behaviors for NPCs in the bestiary vs those in the encounter. Most notably bestiary NPCs have some detailed user defined description.
Configuration menu - View commit details
-
Copy full SHA for 32b7b54 - Browse repository at this point
Copy the full SHA 32b7b54View commit details -
Don't set nickname if not given
Removes the odd behavior of the nickname copying the name if no nickname was given. Using None makes it more clear that the nickname is missing entirely. This does make it impossible to remove a nickname once given though.
Configuration menu - View commit details
-
Copy full SHA for bf63496 - Browse repository at this point
Copy the full SHA bf63496View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc3c3ca - Browse repository at this point
Copy the full SHA dc3c3caView commit details -
Replaces old NPC tests with combat NPC tests. Still need bestiary NPC tests.
Configuration menu - View commit details
-
Copy full SHA for 35f39a8 - Browse repository at this point
Copy the full SHA 35f39a8View commit details -
Define property for NPC nickname
Allows defining the reset and empty behaviors within the class itself.
Configuration menu - View commit details
-
Copy full SHA for cbe3c47 - Browse repository at this point
Copy the full SHA cbe3c47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b94c2c - Browse repository at this point
Copy the full SHA 5b94c2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6eb8dcd - Browse repository at this point
Copy the full SHA 6eb8dcdView commit details
Commits on Aug 9, 2023
-
With the split between NPC types, info is a much more helpful command so info all is a useful tool.
Configuration menu - View commit details
-
Copy full SHA for 6c147be - Browse repository at this point
Copy the full SHA 6c147beView commit details -
Configuration menu - View commit details
-
Copy full SHA for ab907d0 - Browse repository at this point
Copy the full SHA ab907d0View commit details -
Perform smite input validation once
The isValidInt method already checks a whole list of values, so there is no need to loop over them as done before.
Configuration menu - View commit details
-
Copy full SHA for bdee2fd - Browse repository at this point
Copy the full SHA bdee2fdView commit details -
Removes duplicates and sort the selection. Ideally would only remove the duplicates.
Configuration menu - View commit details
-
Copy full SHA for 1fb4136 - Browse repository at this point
Copy the full SHA 1fb4136View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.