Npc type split #10
Merged
Npc type split #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation behind this class split is to enable different behaviors for NPCs in the bestiary vs those in the encounter. Most notably bestiary NPCs have some detailed user defined description.
Removes the odd behavior of the nickname copying the name if no nickname was given. Using None makes it more clear that the nickname is missing entirely. This does make it impossible to remove a nickname once given though.
Replaces old NPC tests with combat NPC tests. Still need bestiary NPC tests.
Allows defining the reset and empty behaviors within the class itself.
With the split between NPC types, info is a much more helpful command so info all is a useful tool.
The isValidInt method already checks a whole list of values, so there is no need to loop over them as done before.
Removes duplicates and sort the selection. Ideally would only remove the duplicates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits NPCs into two types, those for the bestiary and those for combat encounters. Bestiary NPCs are designed to be descriptive while combat NPCs are designed to be interactable.