Make batch_size for Presto flexible
#59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
GriffinBabe
approved these changes
Jun 12, 2024
|
It might be convenient to couple the batch and chuck size to each other per standard value. If not I would go from an apply_datacube to a reduce dimension. Being able to both control the batch and chunk size can lead to less optimized inference workflows for less experienced users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
presto-worldcerealwheel was updated andget_presto_featuresnow accepts an optionalbatch_sizeparameter. In this PR, it's now set to 4096 (but not yet tested). Idea is that we can see what works best for our case.