Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

udf memory profiling #57

Closed
jdries opened this issue Jun 12, 2024 · 3 comments · Fixed by #77
Closed

udf memory profiling #57

jdries opened this issue Jun 12, 2024 · 3 comments · Fixed by #77
Milestone

Comments

@jdries
Copy link
Contributor

jdries commented Jun 12, 2024

Current setting of memory overhead is 12GB, which is a bit much for operational production.

Looking up memory consumption shows very clear peaks when presto is invoked. The actual max usage is even higher, because prometheus only records memory at specific instants.

Image

@GriffinBabe
Copy link
Contributor

@jdries I'm creating a branch for this issue and provide you with a script to locally test presto

@kvantricht
Copy link
Contributor

meanwhile already also made a PR to expose batch_size parameter for presto inference #59

@GriffinBabe
Copy link
Contributor

GriffinBabe commented Jun 13, 2024

@jdries I pushed to this branch a script to test presto locally. To make it work I had to go through quite some dependency issues.

  1. Create a new conda environment with python3.10
  2. Clone GFMAP and go to the main branch, run pip3 install --editable .
  3. Clone worldcereal-classification, go to this branch, run pip3 install --editable .
  4. Install the latest presto wheel file with it's dependencies: pip3 install https://artifactory.vgt.vito.be/artifactory/auxdata-public/worldcereal/dependencies/presto_worldcereal-0.1.1-py3-none-any.whl

You should be good to go

@kvantricht kvantricht linked a pull request Jun 24, 2024 that will close this issue
@kvantricht kvantricht added this to the System V1 milestone Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants