Skip to content

S196 parallelize pipeline deletion #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eschultink wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

S196 parallelize pipeline deletion #80

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f55e625
parallelize pipeline deletion
eschultink Apr 1, 2025
3747bff
Merge branch 'main' into s196-parallelize-pipeline-deletion
eschultink Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 28 additions & 6 deletions java/src/main/java/com/google/appengine/tools/pipeline/impl/backend/AppEngineBackEnd.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,11 +748,33 @@ public void deletePipeline(JobRunId pipelineRunId, boolean force)
}
}

deleteAll(JobRecord.DATA_STORE_KIND, pipelineKey);
deleteAll(Slot.DATA_STORE_KIND, pipelineKey);
deleteAll(ShardedValue.DATA_STORE_KIND, pipelineKey);
deleteAll(Barrier.DATA_STORE_KIND, pipelineKey);
deleteAll(JobInstanceRecord.DATA_STORE_KIND, pipelineKey);
deleteAll(FanoutTaskRecord.DATA_STORE_KIND, pipelineKey);
List<String> kindsToDelete = Arrays.asList(
JobRecord.DATA_STORE_KIND,
Slot.DATA_STORE_KIND,
ShardedValue.DATA_STORE_KIND,
Barrier.DATA_STORE_KIND,
JobInstanceRecord.DATA_STORE_KIND,
ExceptionRecord.DATA_STORE_KIND
Copy link

Copilot AI Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated deletion list replaces FanoutTaskRecord with ExceptionRecord. Confirm whether this change is intentional or if FanoutTaskRecord should also be deleted.

Suggested change
ExceptionRecord.DATA_STORE_KIND
ExceptionRecord.DATA_STORE_KIND,
FanoutTaskRecord.DATA_STORE_KIND

Copilot uses AI. Check for mistakes.
);

kindsToDelete.parallelStream()
.forEach(kind -> deleteAll(kind, pipelineKey));
}

private <R> R attemptWithRetries(Retryer<R> retryer, final Operation<R> operation) {
try {
return retryer.call(operation);
} catch (ExecutionException e) {
log.log(Level.WARNING, "Non-retryable exception during " + operation.getName(), e.getCause());
throw new RuntimeException(e.getCause());
} catch (RetryException e) {
if (e.getCause() instanceof RuntimeException) {
log.warning(e.getCause().getMessage() + " during " + operation.getName()
+ " throwing after 5 multiple attempts ");
throw (RuntimeException) e.getCause();
} else {
throw new RuntimeException(e);
}
}
}
}
Loading