S196 parallelize pipeline deletion #80
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschultink
requested review from
aperez-worklytics,
Copilot and
jlorper
and removed request for
aperez-worklytics
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to parallelize the deletion of pipeline components by replacing sequential deleteAll calls with a parallel stream.
- Replaces sequential deletion calls with a parallelStream approach.
- Updates the list of kinds to delete by replacing FanoutTaskRecord with ExceptionRecord.
Comments suppressed due to low confidence (1)
java/src/main/java/com/google/appengine/tools/pipeline/impl/backend/AppEngineBackEnd.java:760
- Ensure that the deleteAll method is thread-safe as it is now invoked in parallel.
kindsToDelete.parallelStream()
| ShardedValue.DATA_STORE_KIND, | ||
| Barrier.DATA_STORE_KIND, | ||
| JobInstanceRecord.DATA_STORE_KIND, | ||
| ExceptionRecord.DATA_STORE_KIND |
There was a problem hiding this comment.
The updated deletion list replaces FanoutTaskRecord with ExceptionRecord. Confirm whether this change is intentional or if FanoutTaskRecord should also be deleted.
Suggested change
| ExceptionRecord.DATA_STORE_KIND | |
| ExceptionRecord.DATA_STORE_KIND, | |
| FanoutTaskRecord.DATA_STORE_KIND |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Change implications