fix(Avatar): Support for Non-Square Input Image for Avatar component #2337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunguyen19
force-pushed
the
issue-1960-avatar
branch
from
4982062 to
201a786
Compare
thunguyen19
changed the title
Passing run #6176 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
This is ready for review. |
RayRedGoose
added
ready for review
|
Hey! Can you add the example you have in the PR description as an actual example please! |
| @@ -35,6 +36,12 @@ export interface AvatarProps extends React.ButtonHTMLAttributes<HTMLButtonElemen | |||
| * Will render an `div` tag instead of a `button` when defined. | |||
| */ | |||
| as?: 'div'; | |||
| /** | |||
| * The object-fit CSS property sets how the content of a replaced element, | |||
| * such as an <img> or <video>, should be resized to fit its container. | |||
There was a problem hiding this comment.
We can maybe add something like If you image is not a square, you can use this property to ensure the image is rendered properly.
thunguyen19
force-pushed
the
issue-1960-avatar
branch
from
201a786 to
11b695e
Compare
mannycarrera4
approved these changes
Sep 19, 2023
mannycarrera4
added
automerge
and removed
ready for review
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #1960
Added new property to Avatar component
object-fitto support setting the content of a image to be resized to fit its container.Release Category
Components