-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Convert Select from Main into a compound component #2309
feat: Convert Select from Main into a compound component #2309
Conversation
1 flaky test on run #6348 ↗︎
Details:
cypress/integration/Autocomplete.spec.ts • 1 flaky testReview all test suite changes for PR #2309 ↗︎ |
modules/react/collection/stories/examples/DynamicItemsObjects.tsx
Outdated
Show resolved
Hide resolved
if (matchIndex === -1) { | ||
matchIndex = getIndexByStartString(0, keySofar.current, start); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So after this step matchIndex
will be always more than -1
or there is any possibility matchIndex
will be 0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it's the first item
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @RayRedGoose means to say "is there any possibility matchIndex
will be -1
"? A 0
means match found and it is the first item. This logic forces a wrap around from the current cursor, but it is possible a match is still not found.
Co-authored-by: Raisa Primerova <[email protected]>
Co-authored-by: Raisa Primerova <[email protected]>
Co-authored-by: Raisa Primerova <[email protected]>
…/canvas-kit into mc-compound-select
…/canvas-kit into mc-compound-select
Summary
Fixes: #1932
Release Category
Components
BREAKING CHANGES
Select
in Main into a compound component. This component matches our pattern of providing access to lower-level elements and allows for more flexibility.Select
in Preview. You may still consume this component but suggest migrating over to the one in Main.Checklist
ready for review
has been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)