-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Revert removal of Menu in Preview #2335
fix: Revert removal of Menu in Preview #2335
Conversation
Preview and the `Menu` in Main. | ||
|
||
## Deprecations | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think anything needs to go into the upgrade guide since we deprecated it in v8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me.
Removing the ## Deprecations
heading also makes sense since that section is empty, though this means we should also remove the Deprecations line in the table of contents at the top.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we not deprecating anything in v10?
1 flaky test on run #6136 ↗︎
Details:
cypress/integration/Autocomplete.spec.ts • 1 flaky testThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
I'm referencing #2247 (the original PR to remove the Preview Menu) as I'm reviewing this PR to add the Preview Menu back in. Not all of those changes are being reverted here, which I think is ok, but I wanted to call them out to make sure we're being intentional about it:
|
Summary
Fixes: #2333
Release Category
Components
Release Note
We're going to continue supporting the Menu in Preview until we implement grouped menu items (with virtualization) for the Menu in Main.
Checklist
ready for review
has been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)