Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Still support Menu in Preview in v10 while we sort out virtualization for grouping #2333

Closed
mannycarrera4 opened this issue Sep 8, 2023 · 0 comments · Fixed by #2335
Closed

fix: Still support Menu in Preview in v10 while we sort out virtualization for grouping #2333

mannycarrera4 opened this issue Sep 8, 2023 · 0 comments · Fixed by #2335
Labels
10.x bug Something isn't working review in progress Code is currently under review

Comments

@mannycarrera4
Copy link
Contributor

mannycarrera4 commented Sep 8, 2023 •
edited by myvuuu
Loading

🐛 Bug Report

Instead of removing Menu in Preview, we should still support it while we figure out how virtualization is going to work with grouped items. There seems to be nested virtualization and before we remove Menu in Preview, we should support grouping in Main.

Success Criteria

  • Menu in Preview is available for CK users to access in v10
@mannycarrera4 mannycarrera4 added bug Something isn't working 10.x labels Sep 8, 2023
@jaclynjessup jaclynjessup moved this to 🆕 New in Canvas Kit Sep 8, 2023
@mannycarrera4 mannycarrera4 mentioned this issue Sep 12, 2023
Merged
10 tasks
@myvuuu myvuuu moved this from 🆕 New to ✅ Done in Canvas Kit Sep 12, 2023
@myvuuu myvuuu moved this from ✅ Done to 👀 In review in Canvas Kit Sep 12, 2023
@myvuuu myvuuu added the ready for review Code is ready for review label Sep 12, 2023
@jamesfan jamesfan linked a pull request Sep 12, 2023 that will close this issue
fix: Revert removal of Menu in Preview #2335
Merged
10 tasks
@jamesfan jamesfan added review in progress Code is currently under review and removed ready for review Code is ready for review labels Sep 12, 2023
alanbsmith pushed a commit that referenced this issue Sep 12, 2023
@mannycarrera4
fix: Revert removal of Menu in Preview (#2335)
06bda48 
Fixes: #2333

[category:Components]

Release Note:
We're going to continue supporting the Menu in Preview until we implement grouped menu items (with virtualization) for the Menu in Main.

Co-authored-by: manuel.carrera <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Canvas Kit Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
10.x bug Something isn't working review in progress Code is currently under review
Projects
Canvas Kit
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Revert removal of Menu in Preview mannycarrera4/canvas-kit
3 participants
@jamesfan @mannycarrera4 @myvuuu