Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Convert Select from Main into a compound component #2309

Merged
merged 129 commits into from
Oct 20, 2023
Merged
Show file tree
Hide file tree
Changes from 119 commits
Commits
Show all changes
129 commits
Select commit Hold shift + click to select a range
171073f
feat: Add compound select
Jul 25, 2023
de04163
feat: Select compound with t ypeahead
Jul 26, 2023
552b9a4
fix: Working through static api
Jul 27, 2023
5e7ce6d
fix: Clean up some logic
Aug 1, 2023
dff9d5e
feat: Update behavior
Aug 3, 2023
0c59085
fix: Merge both hooks
Aug 3, 2023
e163219
fix: Only call keyboard when popup is visible
Aug 7, 2023
9f059c5
fix: Add list visibility config to usecursormodel
Aug 8, 2023
6c41768
fix: Clean up keyboard handler add tests
Aug 8, 2023
7a8c290
fix: Update behavior based on spec
Aug 9, 2023
1fe556e
fix: Clean up type ahead
Aug 10, 2023
088b4fb
fix: Clean up code and add comments
Aug 15, 2023
cfc42c4
fix: Clean up more
Aug 15, 2023
0463ac3
fix: Undo autocomplete changes
Aug 17, 2023
208a5fc
fix: Update test
Aug 17, 2023
31dd4d6
fix: Update on click behavior
Aug 17, 2023
85ca59a
fix: CLean up cypress to wait
Aug 17, 2023
062a722
fix: Update test to check aria selected
Aug 17, 2023
1af19b5
fix: Remove type any
Aug 17, 2023
2415b24
fix: Remove T type
Aug 17, 2023
12b5faf
fix: Clean up imports
Aug 17, 2023
acf0718
fix: Add select model
Aug 17, 2023
fe2f37c
fix: Clean up select input and create model
Aug 18, 2023
ee246db
fix: Clean up types
Aug 18, 2023
9f7036e
fix: Clean up props
Aug 18, 2023
d4c22dd
fix: Clean up combobox
Aug 18, 2023
6ed1b06
fix: Working on static api
Aug 21, 2023
629c12d
fix: Clean up code, add docs
Aug 22, 2023
548b78d
fix: Remove test for escape
Aug 25, 2023
2595fb4
fix: Clean up hook and name of component
Aug 25, 2023
779d94d
fix: Clean up input select
Aug 25, 2023
58d5c1e
fix: Clean up chromatic tests
Aug 28, 2023
7f997d6
test: Update tests to use compound component
Aug 28, 2023
f2d75dc
fix: Clean up storybook example
Aug 28, 2023
2f2febb
fix: Clean up consoles
Aug 28, 2023
394080a
fix: Rename and add test
Aug 28, 2023
9f5f57a
fix: Update story
Aug 28, 2023
adbcc31
fix: Add docs and stories
Aug 30, 2023
1dc6256
fix: File clean up
Aug 30, 2023
c70a3fe
fix: Undo files changes
Aug 30, 2023
1a039c0
fix: Clean up docs on select
Aug 31, 2023
c66d30f
fix: Update mdx file
Aug 31, 2023
a9b26d6
fix: Add mdx docs
Sep 1, 2023
10f6bb9
fix: Clean up docs
Sep 1, 2023
c0a2198
fix: Remove combobox menu popper
Sep 1, 2023
5280d72
fix: Clean up docs
Sep 5, 2023
6233311
fix: Clean up docs and pointset size
Sep 5, 2023
9833e6a
fix: Add type for ref
Sep 5, 2023
9311d96
fix: Add useselectcard
Sep 5, 2023
1b24e52
fix: Clean up useselectinput
Sep 6, 2023
86cc3f8
fix: Remove conole
Sep 6, 2023
bc222b2
fix: Clean up hooks
Sep 6, 2023
2e7d661
fix: Modify disabled options
Sep 7, 2023
6b41512
fix: Clean up use hook for select item
Sep 7, 2023
6e1cbfa
fix: Clean up icons story
Sep 7, 2023
bf220f6
fix: Clean up disabled options
Sep 7, 2023
37f4105
fix: Clean up disabled options and hoisted model
Sep 11, 2023
07b1509
fix: Deprecate select in preview
Sep 13, 2023
7c3940c
fix: Clean up test file
Sep 13, 2023
ff53f15
fix: Clean up test and deprecation warning
Sep 13, 2023
2192f16
fix: Update test
Sep 13, 2023
561aee7
test: Update test spec file
Sep 14, 2023
4c27ff9
fix: Update test
Sep 14, 2023
803d350
fix: Update test
Sep 14, 2023
1aa66dd
fix: Update docs
Sep 14, 2023
d6530d2
fix: Update file name
Sep 14, 2023
d21fc16
fix: Update request annimation
Sep 15, 2023
adb0429
Merge branch 'prerelease/major' of https://github.com/Workday/canvas-…
Sep 18, 2023
5318815
fix: Update docs
Sep 18, 2023
56f3e57
fix: Remove unused import
Sep 18, 2023
375f71e
fix: Add select preview to upgrade guide
Sep 18, 2023
ef6293d
fix: Update docs per sir james
Sep 19, 2023
475573a
Update modules/react/combobox/lib/ComboboxMenuItem.tsx
mannycarrera4 Sep 20, 2023
4db9a5f
fix: Clean up some logic
Sep 20, 2023
9456afb
Update modules/react/select/stories/Select.stories.mdx
mannycarrera4 Sep 21, 2023
a9e2a23
Update modules/react/select/stories/examples/WithIcons.tsx
mannycarrera4 Sep 21, 2023
9836d8a
Update modules/react/select/stories/Select.stories.mdx
mannycarrera4 Sep 21, 2023
15db1e2
fix: Clean up docs
Sep 22, 2023
0729797
Merge branch 'prerelease/major' of https://github.com/Workday/canvas-…
Sep 22, 2023
70122ce
fix: Working through documentation
Sep 22, 2023
9547732
Update modules/react/select/lib/hooks/useSelectInput.ts
mannycarrera4 Sep 25, 2023
a28fb60
Merge branch 'mc-compound-select' of https://github.com/mannycarrera4…
Sep 25, 2023
da52f00
fix: Update to latest
Sep 25, 2023
751cc30
fix: More code cleanup and refactoring
Sep 26, 2023
78a5867
fix: Clean up use hooks
Sep 27, 2023
19ba6a0
fix: Clean up hooks
Sep 27, 2023
2f11545
test: Update spec file
Sep 27, 2023
345ca14
test: Update spec test
Sep 27, 2023
2262ba2
fix: Clean up max height and add register items story
Sep 27, 2023
189cb05
fix: Update dep jsdoc
Sep 28, 2023
0228734
fix: Update fallback placement on select to be top or bottom
Sep 28, 2023
3359df9
fix: Update example
Sep 28, 2023
9cfc3e1
fix: Update upgrade guide
Sep 28, 2023
54e3068
fix: Update upgrade guide
Sep 28, 2023
7a4791b
fix: Update dep sentence
Sep 28, 2023
6174850
fix: Update dep m essages
Sep 28, 2023
4631e1c
fix: Update dep warning and index for collection
Sep 28, 2023
65cb2c8
Update modules/react/collection/stories/examples/RegisteringItems.tsx
mannycarrera4 Sep 28, 2023
aec3c06
fix: Clean comment
Sep 28, 2023
ba496d4
Merge branch 'mc-compound-select' of https://github.com/mannycarrera4…
Sep 28, 2023
dc5f756
fix: Remove unused code
Sep 28, 2023
f2986bc
fix: Clean up hooks and comments
Sep 29, 2023
f5c36cf
fix: Update comment
Oct 6, 2023
3d7db13
fix: Rename hook to avoid conflict
Oct 9, 2023
d5570f0
docs: Clean up Collection docs and examples
jamesfan Oct 9, 2023
75b8eb7
docs: Clean up Select docs and examples
jamesfan Oct 9, 2023
760384a
docs: Update examples to use implicit return
jamesfan Oct 9, 2023
0abdd19
docs: Rename Scrollable story to MenuHeight
jamesfan Oct 9, 2023
445620d
docs: Remove broken link
jamesfan Oct 9, 2023
fef8f43
fix: Remove data from object
Oct 10, 2023
203b505
fix: Update stories
Oct 10, 2023
c51adb4
fix: Update basic for cypress
Oct 10, 2023
28debfe
fix: Update test
Oct 10, 2023
2516cce
fix: Update after merge conflicts
Oct 19, 2023
9b5f4f0
fix: Remove merge conflict
Oct 19, 2023
0dbbb49
fix: Clean up bad merge manny
Oct 19, 2023
ea09a70
fix: Clean up move to cursor
Oct 19, 2023
57401fc
fix: Clean up docs
Oct 20, 2023
03ce6a3
fix: Update test type
Oct 20, 2023
8ffb288
Update modules/react/combobox/lib/hooks/useMoveCursorToIndex.tsx
mannycarrera4 Oct 20, 2023
e7dbdd2
fix: Clean up logic
Oct 20, 2023
8781296
fix: Clean up logic
Oct 20, 2023
d657a6d
Update modules/react/select/stories/stories_VisualTesting.tsx
mannycarrera4 Oct 20, 2023
ef042c3
Update modules/react/select/stories/stories_VisualTesting.tsx
mannycarrera4 Oct 20, 2023
ffb7200
fix: Clean up hooks and logic
Oct 20, 2023
ce646b0
Merge branch 'mc-compound-select' of https://github.com/mannycarrera4…
Oct 20, 2023
64e8606
Merge branch 'prerelease/major' into mc-compound-select
mannycarrera4 Oct 20, 2023
0610546
fix: Update test
Oct 20, 2023
3bfe4a6
Merge branch 'mc-compound-select' of https://github.com/mannycarrera4…
Oct 20, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .storybook/routes.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const routes = {
'/components/inputs/color-input/': 'components-inputs-color-picker-color-input--basic',
'/components/inputs/form-field/': 'components-inputs-form-field--basic',
'/components/inputs/radio/': 'components-inputs-radio--basic',
'/components/inputs/select/': 'preview-select-top-label--default',
'/components/inputs/select/': 'components-inputs-select--basic',
'/components/inputs/switch/': 'components-inputs-switch--basic',
'/components/inputs/text-area/': 'components-inputs-textarea--basic',
'/components/inputs/text-input/': 'components-inputs-text-input--basic',
Expand Down
10 changes: 1 addition & 9 deletions cypress/integration/Autocomplete.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,21 +105,13 @@ describe('Autocomplete', () => {
cy.findByRole('combobox').type('{esc}');
});

it('should clear the combobox', () => {
cy.findByRole('combobox').should('have.value', '');
});

it('should close the listbox', () => {
cy.findByRole('listbox').should('not.exist');
});

it('should keep focus on the combobox', () => {
cy.findByRole('combobox').should('have.focus');
});

it('should not show the clear button', () => {
cy.get('[data-testid=clear]').should('not.be.visible');
});
mannycarrera4 marked this conversation as resolved.
Show resolved Hide resolved
});

context('when the clear button is clicked', () => {
Expand Down Expand Up @@ -332,7 +324,7 @@ describe('Autocomplete', () => {
});
});
});

context('when the user types in a value not found', () => {
beforeEach(() => {
cy.findByRole('combobox').type('Peach');
Expand Down
Loading
Loading