Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trac: Changes required for the new WordPress.org header #50

Closed
wants to merge 14 commits into from

Conversation

dd32
Copy link
Member

@dd32 dd32 commented Jan 14, 2022

This is a PR for migrating Trac to the new WordPress.org headers. See WordPress/wporg-mu-plugins#53

  • New header/footer are pulled from w.org, saved to their respective files
  • DomDocument is used to convert it from HTML5 to XHTML compatible output
  • Some cleanups are done to make the XHTML script/style tags valid for browser & Trac HTML parser compatibility
  • Invalid HTML from the header is fixed. Search menu item is invalid HTML wporg-mu-plugins#87
  • There are several load-order issues on the Trac side still, resulting in JS errors jQuery is not loaded for the Header, instead relying upon the jQuery 1.x loaded by Trac.
  • Search is redirected to Trac Search
  • Skip link is directed to the correct Trac element

@dd32
Copy link
Member Author

dd32 commented Jan 14, 2022

TESTTRAC

@dd32
Copy link
Member Author

dd32 commented Jan 18, 2022

Turned out that the jQuery issues were caused by the WordPress.org headers loading jQuery 3.x, but Trac using (and bundling) jQuery 1.x.

I've updated the script to exclude the jQuery <script> and everything seems to be working.

@dd32 dd32 marked this pull request as ready for review January 18, 2022 05:13
@bazza bazza closed this in 7171e0b Jan 24, 2022
@dd32 dd32 deleted the add/new-header branch May 19, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant