Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate new header/footer into Trac #53

Closed
4 of 6 tasks
iandunn opened this issue Jan 4, 2022 · 9 comments
Closed
4 of 6 tasks

Integrate new header/footer into Trac #53

iandunn opened this issue Jan 4, 2022 · 9 comments
Labels
[Type] Enhancement New feature or request
Milestone

Comments

@iandunn
Copy link
Member

iandunn commented Jan 4, 2022

It should use the endpoint from #45, and we should do this in parallel to that issue, so that feedback can be given to shape how the endpoint is created

  • do brain dump on how to update/test trac templates
  • turn brain dump into docs
  • pull API response into trac env and cache there
  • integrate cached markup into trac templates
  • give feedback on setup REST API endpoints for sites outside the network #45 and iterate there
  • test on production behind feature flag (if convenient)
@iandunn iandunn added the [Type] Enhancement New feature or request label Jan 4, 2022
@iandunn iandunn added this to the News launch milestone Jan 4, 2022
@iandunn
Copy link
Member Author

iandunn commented Jan 4, 2022

@dd32 IIRC you're one of the few people how knows how to edit and test the Trac templates, do you mind doing a brain dump here with the important stuff that someone else would need to know?

Is it just setting up a local Trac install w/ the templates from meta.svn ? Any quirks or confusing stuff?

@iandunn
Copy link
Member Author

iandunn commented Jan 4, 2022

There's a rough version of the API available at these URLs:

We'll need feedback on how well that approach works for Trac.

@dd32
Copy link
Member

dd32 commented Jan 14, 2022

Is it just setting up a local Trac install w/ the templates from meta.svn ? Any quirks or confusing stuff?

Yes, and yes.

There's a bunch of Quirks, some of which require customising the templates from meta. For testing some components of Trac, you also need to write a custom trac-wsgi.py to allow authentication, or to route requests correctly.
You can mostly just put the template directory on top of a regular Trac install and be able to do most things, but digging deeper requires dealing with the quirks.

WordPress/wordpress.org#50 is some initial work to make it work, I've gone with a local script initially, but we may be able to convert it to auto-updating one from the rest endpoints.

@iandunn
Copy link
Member Author

iandunn commented Jan 14, 2022

👍🏻 thanks!

@dd32
Copy link
Member

dd32 commented Jan 18, 2022

WordPress/wordpress.org#50 is ready for use when we roll the header out.

See #45 above for some other discussion about ways to implement this within Trac.

@iandunn iandunn mentioned this issue Jan 19, 2022
5 tasks
@iandunn
Copy link
Member Author

iandunn commented Jan 19, 2022

@dd32 is there anything left to do here, other than deploy stuff on launch day?

@dd32
Copy link
Member

dd32 commented Jan 20, 2022

Nope! I think it's all launch-day stuff now. I'll close this in preference for #100

@dd32 dd32 closed this as completed Jan 20, 2022
@dd32
Copy link
Member

dd32 commented Jan 20, 2022

turn brain dump into docs

Just noting that I've started collating my testing info into dd32/trac-w-org-env#1

It's not a working environment, but is where I'll make it happen if I get to it.

@iandunn
Copy link
Member Author

iandunn commented Jan 20, 2022

That's great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants