Try adding blockquote styles

[kjellr]

Alternate to #184. I spent a little time giving this a try too, and got it pretty close.

Should work well with left/center/right-aligned quotes. The only bug I know of at the moment is that the extra margin I add on small screen sizes to house the blockquotes is eaten up by higher-specificity global margins on the front end:

I won't be able to work on solving that until tomorrow morning, so if someone else would like to pick this up feel free. If we get #184 cleaned up first, that's fine too. Thanks!

[ryelle]

I've iterated on this a bit to fix up the small screen quotes and some issues in the editor. The only question I have left is whether the de-bolding of strong should also affect the cite content — I've talked this through with @melchoyce and toggling bold on in the quote correctly unbolds the content, but if you bold something in the citation it does nothing right now.

Some screenshots from Mac/Firefox:

Front end, desktop

Editor, desktop

Front-end, mobile

[ryelle]

@melchoyce mentioned the citations should not be italics, so I've pushed a fix for that; and I also noticed that things were out of alignment in the editor on a wide screen (wider than my screenshot above), so I've fixed that too.

[melchoyce]

LGTM 👍

[carolinan]

This is a comparison between this PR (right) and #453

And I think they both have different issues, with the alignments, weight, and the citation.

[kjellr]

Thank you for the improvements, @ryelle!

I think they both have different issues, with the alignments, weight, and the citation.

Regarding the alignments, this PR intentionally leaves off the quotation mark accent on the center version, and right-aligns it when the quote is right aligned. I prefer that to the treatment in #453.

This PR uses a 600 font weight for the text instead of 700. The theme uses 600 for bold headings and the pagination titles and that's what I pulled that from, but I see that the pullquote block and widget font titles use a 700 weight. We may want to align those, but I'll leave it to @melchoyce to make the final call on that.

It looks like #453 adds a hyphen + a non-breaking space before the citation (If we go with that, typography rulebooks typically suggest it should be an em-dash instead of a hypen). In general though, I personally prefer letting users enter that themselves.

[carolinan]

-Then let's use this one.

I can't take preference in consideration if it is not documented why decisions were made.

[melchoyce]

This PR more accurately reflects the design I intended.

This PR uses a 600 font weight for the text instead of 700. The theme uses 600 for bold headings and the pagination titles and that's what I pulled that from, but I see that the pullquote block and widget font titles use a 700 weight. We may want to align those, but I'll leave it to @melchoyce to make the final call on that.

Let's go with 700 👍

It looks like #453 adds a hyphen + a non-breaking space before the citation (If we go with that, typography rulebooks typically suggest it should be an em-dash instead of a hypen). In general though, I personally prefer letting users enter that themselves.

Yeah, @ryelle asked me about this too, and I said I'd rather leave it up to people to add it if they want it.

[kjellr]

Let's go with 700

Updated!

[carolinan]

The conflict needs to be resolved, but I am not sure what else this PR is waiting for?

[aristath]

Code looks good to me, and since design has already approved it I believe this is OK to merge 👍

[aristath]

Resolved merge conflicts and merged