This repository has been archived by the owner on Dec 2, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 117
Fix/implement block quote design #453
Closed
JustinyAhin
wants to merge
8
commits into
WordPress:trunk
from
JustinyAhin:fix/implement-block-quote-design
Closed
Fix/implement block quote design #453
JustinyAhin
wants to merge
8
commits into
WordPress:trunk
from
JustinyAhin:fix/implement-block-quote-design
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melchoyce
suggested changes
Oct 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JustinyAhin! Thanks for taking this on.
I'm seeing a couple design issues:
- The alignment of the quotes isn't inside the content width in the editor:
- The quotation marks should show up inside the editor, like the pullquote block:
- The quotation mark spacing on the front-end isn't right:
The upper edge of the quotation mark should align to the top of the text, and should be 20px to the left of the text.
Let me know if you have any questions!
Thanks for looking @melchoyce . |
rolf-yoast
reviewed
Oct 15, 2020
ryelle
suggested changes
Oct 15, 2020
Closing this in favor of #513. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #184.
Summary
Relevant technical choices:
No.
Test instructions
Add two block quotes in the editor
In frontend, they should look like the model in this figma file https://www.figma.com/file/OEtsCj8oD8JPVx4OvsS0U2/Twenty-Twenty-One?node-id=1254%3A0.
Screenshots
Quote block in the editor before
Quote block in the editor after
Quote block in frontend before
Quote block in frontend after
Quality assurance