Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

Fix/implement block quote design #453

Closed
wants to merge 8 commits into from
Closed

Fix/implement block quote design #453

wants to merge 8 commits into from

Conversation

JustinyAhin
Copy link
Member

Fixes #184.

Summary

Relevant technical choices:

No.

Test instructions

Add two block quotes in the editor
In frontend, they should look like the model in this figma file https://www.figma.com/file/OEtsCj8oD8JPVx4OvsS0U2/Twenty-Twenty-One?node-id=1254%3A0.

Screenshots

Quote block in the editor before
block-quote-editor-before

Quote block in the editor after
block-quote-editor-after

Quote block in frontend before
block-quote-frontend-before

Quote block in frontend after
block-quote-frontend-after

Quality assurance

  • I have thought about any security implications this code might add.
  • I have checked that this code doesn't impact performance (greatly).
  • I have tested this code to the best of my abilities
  • I have checked that this code does not affect the accessibility negatively

@JustinyAhin JustinyAhin marked this pull request as ready for review October 13, 2020 16:49
@melchoyce melchoyce self-requested a review October 13, 2020 16:52
Copy link
Contributor

@melchoyce melchoyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JustinyAhin! Thanks for taking this on.

I'm seeing a couple design issues:

  1. The alignment of the quotes isn't inside the content width in the editor:

image

  1. The quotation marks should show up inside the editor, like the pullquote block:

image

  1. The quotation mark spacing on the front-end isn't right:

image

The upper edge of the quotation mark should align to the top of the text, and should be 20px to the left of the text.

Let me know if you have any questions!

@JustinyAhin
Copy link
Member Author

Thanks for looking @melchoyce .
Working on your changes request.

@JustinyAhin
Copy link
Member Author

JustinyAhin commented Oct 14, 2020

The alignment of the quotes isn't inside the content width in the editor:

This is not related to the new implemented design. The quote block is initially not aligned with the content width. I think this should be solved in another issue.

Screenshot_2020-10-14 Edit Post ‹ trunk wordpress test — WordPress

assets/sass/01-settings/global.scss Outdated Show resolved Hide resolved
assets/sass/05-blocks/quote/_editor.scss Outdated Show resolved Hide resolved
assets/sass/05-blocks/quote/_editor.scss Outdated Show resolved Hide resolved
assets/sass/05-blocks/quote/_style.scss Outdated Show resolved Hide resolved
assets/sass/05-blocks/quote/_style.scss Show resolved Hide resolved
assets/sass/05-blocks/quote/_style.scss Outdated Show resolved Hide resolved
assets/sass/05-blocks/quote/_style.scss Outdated Show resolved Hide resolved
assets/sass/05-blocks/quote/_style.scss Outdated Show resolved Hide resolved
@carolinan
Copy link
Contributor

Closing this in favor of #513.

@carolinan carolinan closed this Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the design of the quote block
5 participants