Adjust allow pattern overrides UX flow #60769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Enhancement
|
Size Change: -3.31 kB (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
22 tasks
|
Looks good. I have a few tweaks I'll push up in a bit, to copy mostly. |
|
Make small tweaks to add more clarity/touch-up the design:
|
|
Flaky tests detected in a5bad82. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8721222278
|
t-hamano
reviewed
Apr 17, 2024
There was a problem hiding this comment.
What do you think about removing "overrides" from button text? Having the modal title and button text match feels a little redundant to me. This might also prevent the button from becoming too wide when the text is localized. Or would "OK", "Apply", etc. also match?
Just to connect a dot; there's an established convention where the confirmatory button label matches the action, and ideally we respect that here rather than diverging towards "Apply" or "OK". I agree they can be shorter though: "Enable" / "Disable". |
t-hamano
reviewed
Apr 17, 2024
Co-authored-by: Aki Hamano <[email protected]>
t-hamano
approved these changes
Apr 17, 2024
28 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Close #60760.
Refine the UX flow of the "allow overrides" button for Pattern Overrides. The wording is still TBD and can be changed.
Why?
So that the UX flow can just be buttons and modals.
How?
Add a
DisallowOverridesModal.Testing Instructions
Screenshots or screencast
Kapture.2024-04-16.at.15.47.05.mp4