Extract pattern-overrides code from the block-editor package #60887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Feature] Synced Patterns
22 tasks
|
Size Change: +351 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
talldan
reviewed
Apr 19, 2024
Comment on lines
164
to
176
| export default function RenameBlockModalControl() { | ||
| const { renamingBlockClientId } = useSelect( | ||
| ( select ) => ( { | ||
| renamingBlockClientId: unlock( | ||
| select( patternsStore ) | ||
| ).getRenamingBlockClientId(), | ||
| } ), | ||
| [] | ||
| ); | ||
| if ( ! renamingBlockClientId ) return null; | ||
|
|
||
| return <BlockRenameModal clientId={ renamingBlockClientId } />; | ||
| } |
There was a problem hiding this comment.
Wondering if you'd considered the BlockSettingsMenuControls slot to add the pattern specific rename action? It looks like the fills handily get rendered right after the rename menu item:
Then it might just require a allowBlockRenaming: false editor setting then to remove the normal rename action.
There was a problem hiding this comment.
My idea is to avoid customizing through the controls so that we can reuse the same renameBlock function for commands and other renaming flows as well. We can consider supporting both if needed though, but to me it's not necessary for now. Does it make sene?
|
Flaky tests detected in 0004087. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8751715773
|
kevin940726
force-pushed
the
update/pattern-overrides-rename-extraction
branch
from
0004087 to
16fd393
Compare
kevin940726
commented
Apr 19, 2024
| } } | ||
| aria-expanded={ renamingBlock } |
There was a problem hiding this comment.
Since we're opening a dialog and we won't be able to access this element when the dialog is open, I don't see why we need this 🤔. I could be wrong though so could use a sanity check from @Mamaduka. 🙏
There was a problem hiding this comment.
You're right. The content behind the dialog become "inert" and browser should ignore them. Adding them to few menu items with modals was my mistake.
|
Closing this one due to the comment here - #60619 (comment). Thanks for working on this though and sorry for the u-turn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Close #60619. Extract pattern-overrides code from the block-editor package.
I'm not entirely sure that the code duplication is worth the effort 😅, so I'll leave this as a draft for now.
Why?
Pattern overrides is a WP-only feature, which shouldn't be inside the
block-editorpackage.How?
Use a private
renameBlockeditor setting to register different flow. This can be further extended when we support renaming blocks via other UI actions (shortcut, command, etc).Testing Instructions
The original renaming flow should still work as expected.
Follow the same testing instructions in #60234 and #60769.
Screenshots or screencast
N/A