Template inspector: Surface related patterns #55091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Enhancement
scruffian
commented
Oct 5, 2023
packages/edit-site/src/components/sidebar-edit-mode/template-panel/template-actions.js
Show resolved
Hide resolved
scruffian
commented
Oct 5, 2023
| if ( ! title && ! description ) { | ||
| return null; | ||
| } | ||
|
|
||
| const onTemplateSelect = async ( selectedTemplate ) => { | ||
| await editEntityRecord( 'postType', postType, postId, { |
There was a problem hiding this comment.
Since record is already an entity can we edit it directly?
There was a problem hiding this comment.
We cannot directly mutate a record as that way the store update would not propagate. Instead, we need to call editEntityRecord as we are doing currently.
scruffian
commented
Oct 5, 2023
| ) | ||
| ), | ||
| } ) ); | ||
| return patterns.filter( |
There was a problem hiding this comment.
Should we also filter out the currently used pattern? Can we if we don't know which one it is?
There was a problem hiding this comment.
I don't think it's possible to determine the pattern used after it has been applied as there is no information available about the pattern used.
There was a problem hiding this comment.
Maybe we can save the slug in the metadata like we do in #59251 - then we will have a way to know.
|
Size Change: -99 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
I don't want to derail but I am confused about why a template is switched with a pattern and not another template. |
Yeah I agree this is confusing. I was initially very confused and built a mechanism for switching templates for other templates, but then I realised that doesn't make sense. If you switch one template part for another then you end up with two template parts that are the same. I think the flow that is actually more useful (although not the one in #44582) is creating a way to switch template parts from within a template. Maybe I'll try to spin up a PR to do that as well... |
|
To get back on topic: I prefer this direct visual preview over the previous option because that option was difficult to find. Some design tweaks are needed, but I understand this is early and a draft. |
carolinan
reviewed
Oct 6, 2023
| @@ -64,6 +96,15 @@ export default function TemplatePanel() { | |||
| > | |||
| <TemplateAreas /> | |||
| </SidebarCard> | |||
| <p> | |||
| { __( | |||
| 'Choose a predefined pattern to switch up the look of your template.' // TODO - make this dynamic? | |||
There was a problem hiding this comment.
I think this can be shortened.
But I also think the switch context is important so that the user doesn't think it will just place another pattern in the editor.
|
Flaky tests detected in 06d4c97. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7975920487
|
scruffian
force-pushed
the
add/patterns-to-template-parts
branch
from
6d2025d to
3bd79a7
Compare
|
This works but makes the impact of the low performance way in which we preview patterns even more visible:
In the current modal version at least once the fiddling with patterns is done the baseline performance of the editor UI is not broken. |
template.part.swap.movTook this for a spin and have a few notes:
|
|
It may be better to put it in a PanelBody, perhaps closed initially. :/ |
| return null; | ||
| } | ||
|
|
||
| return ( |
There was a problem hiding this comment.
FYI, to help with performance, in the other places that we list patterns we have added client-side pagination, eg. https://github.com/WordPress/gutenberg/blob/trunk/packages/edit-site/src/components/page-patterns/patterns-list.js#L210, you may want to think about also adding it here, but could be a follow up.
There was a problem hiding this comment.
When displaying patterns for a particular template or a part of it, we anticipate that we won't have to show too many patterns. However, if this does become a problem, we can revisit the idea of adding pagination in the future.
MaggieCabrera
approved these changes
Oct 26, 2023
|
Removing this PR from the 6.5 board as I removed the associated issue due to lack of movement in the last few months. Happy to add back if that changes but with barely over a week until beta 1 want to be mindful about any last minute updates. |
Squashed commits: [7bc5ee8707] template-panel/index rebase [4d47f77146] Make titles tooltips (+8 squashed commits) Squashed commits: [3488f2f] Layout tweaks [f450cd5] remove CSS [b3990a7] remove unused file [3bd79a7] update comment [e07cd80] Add comments [aaae875] Let users select a pattern [4aa4272] fetch patterns not template parts [3f3da4b] Add template parts to template parts (whoops)
jorgefilipecosta
force-pushed
the
add/patterns-to-template-parts
branch
from
8d1d5c3 to
515bd8a
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
The PR was rebased and a Panel was added. |
This was referenced Feb 20, 2024
creativecoder
added
[Type] Feature
|
👋🏻 Looks like this commit was merged with a failing performance test: What do you folks think should happen? This change deletes Maybe we should update the test to look for "Transform into" instead. I'll have a shot. |
ramonjd
added a commit
that referenced
this pull request
Feb 22, 2024
…e HTML structure. Updating performance tests to find new elements.
ramonjd
added a commit
that referenced
this pull request
Feb 22, 2024
…e HTML structure. (#59259) Updating performance tests to find new elements. Co-authored-by: ramonjd <[email protected]> Co-authored-by: andrewserong <[email protected]>
|
It would be interesting to see the impact of this change on performance. Patterns are parsed and prepared during the load ( The performance test uses the cc @ellatrix |
creativecoder
pushed a commit
that referenced
this pull request
Feb 23, 2024
…e HTML structure. (#59259) Updating performance tests to find new elements. Co-authored-by: ramonjd <[email protected]> Co-authored-by: andrewserong <[email protected]>
|
Yes, I talked to @youknowriad about this. IMO we should be changing a lot of the perf tests to use TT4 which is a "real world" theme. |
youknowriad
pushed a commit
that referenced
this pull request
Mar 4, 2024
…e HTML structure. (#59259) Updating performance tests to find new elements. Co-authored-by: ramonjd <[email protected]> Co-authored-by: andrewserong <[email protected]>
youknowriad
pushed a commit
that referenced
this pull request
Mar 4, 2024
…e HTML structure. (#59259) Updating performance tests to find new elements. Co-authored-by: ramonjd <[email protected]> Co-authored-by: andrewserong <[email protected]>
7 tasks
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #44582
This adds a pattern selector in the template inspector panel. Also removes the replace button added in #54609.
Why?
This makes it much easier for users to switch out templates and template parts for patterns.
How?
Testing Instructions
Screenshots or screencast