Performance tests: update selectors in site editor pattern loading tests #59259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e HTML structure. Updating performance tests to find new elements.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
added
[Type] Automated Testing
andrewserong
approved these changes
Feb 22, 2024
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
andrewserong
added
the
Backport to Gutenberg RC
|
Just updated the milestone to GB 17.8 and added the backport label, as I think this PR will likely need to be cherry picked for the GB release branch in order for its tests to pass. CC: @creativecoder for visibility. |
|
Thanks for tracking this down ❤️ |
|
Thank you, @ramonjd! Unfortunately, this only partially solves this issue. The tests are still failing on Possible solutions:
cc @youknowriad |
ramonjd
added a commit
that referenced
this pull request
Feb 22, 2024
Thanks @Mamaduka I was just wondering that.. 😄
The latter sounds like a neat solution if it doesn't affect stats? I can prep something. |
ramonjd
added a commit
that referenced
this pull request
Feb 22, 2024
This commit makes the test backwards compatible until the performance tests base commit is updated.
|
The problem with updating the base branch is that it has the potential to create a small jump in the graphs, so I think we shouldn't build the habit of changing it too often. If we can make the performance test work in both branch at the same time, it would be better and would allow us to compare a bigger range of branches using the manual perf tests if needed. |
ramonjd
added a commit
that referenced
this pull request
Feb 22, 2024
…ible (#59266) * Update Performance tests base branch after #59259 This commit makes the test backwards compatible until the performance tests base commit is updated. * use locator Co-authored-by: ramonjd <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: Mamaduka <[email protected]>
creativecoder
pushed a commit
that referenced
this pull request
Feb 23, 2024
…e HTML structure. (#59259) Updating performance tests to find new elements. Co-authored-by: ramonjd <[email protected]> Co-authored-by: andrewserong <[email protected]>
|
I just cherry-picked this PR to the release/17.8 branch to get it included in the next release: 7665bdd |
creativecoder
pushed a commit
that referenced
this pull request
Feb 23, 2024
…ible (#59266) * Update Performance tests base branch after #59259 This commit makes the test backwards compatible until the performance tests base commit is updated. * use locator Co-authored-by: ramonjd <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: Mamaduka <[email protected]>
creativecoder
removed
the
Backport to Gutenberg RC
youknowriad
pushed a commit
that referenced
this pull request
Mar 4, 2024
…e HTML structure. (#59259) Updating performance tests to find new elements. Co-authored-by: ramonjd <[email protected]> Co-authored-by: andrewserong <[email protected]>
youknowriad
added a commit
that referenced
this pull request
Mar 4, 2024
…ible (#59266) * Update Performance tests base branch after #59259 This commit makes the test backwards compatible until the performance tests base commit is updated. * use locator Co-authored-by: ramonjd <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: Mamaduka <[email protected]>
youknowriad
pushed a commit
that referenced
this pull request
Mar 4, 2024
…e HTML structure. (#59259) Updating performance tests to find new elements. Co-authored-by: ramonjd <[email protected]> Co-authored-by: andrewserong <[email protected]>
youknowriad
added a commit
that referenced
this pull request
Mar 4, 2024
…ible (#59266) * Update Performance tests base branch after #59259 This commit makes the test backwards compatible until the performance tests base commit is updated. * use locator Co-authored-by: ramonjd <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: Mamaduka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#55091 updated the way templates can be replaced in the site editor, changing some of the HTML structure, namely removing the replace template button in
sidebar-edit-mode/template-panel/replace-template-button.jswith a "transform into" list.This PR just updates the performance tests to find the new elements.
Testing
Wait for 🟢 and 🙏🏻
npx playwright test --config test/performance/playwright.config.ts test/performance/specs/site-editor.spec.js