[Full Site Editing]: Update clear customizations copy for templates
#41765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Copy
ntsekouras
commented
Jun 16, 2022
|
Size Change: +25 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
|
I think this makes sense, and also better covers theme switches. |
|
Agreed that this needs to be iterated upon. I don't know how clear it is to folks that they are essentially creating a custom template when they make changes so that phrasing feels potentially confusing. If I were to select "Use the template as supplied by the theme", I wouldn't immediately think it wouldn't be reverting anything. Some other options:
For some reason, "customized" template rather than "custom template" feels more accurate to the situation. On a more minor note, instead of supplied, my brain went to "defined by the theme" but I don't feel strongly. |
ntsekouras
force-pushed
the
update/clear-customizations-copy-for-templates
branch
from
57e1c89 to
f1f98fd
Compare
|
I think it's important to avoid phrasing like 'restore' or 'revert' because if there is an update to the template since you customized it then the action is no longer a restoration. In that sense, I suppose the 'Clear customizations' part is probably ok. Perhaps it's just the description that needs to be updated.
|
jameskoster
added
the
Needs Copy Review
|
👋 - is this still relevant? If yes, what are we missing to move forward? |
|
👋 I think we should merge the description change, but leave the main button label as 'Clear customizations'. That solves the original issue by removing the potentially misleading 'revert' language. In fact, there is an argument to be made that we could get rid of the secondary label altogether. 'Clear customizations' is possibly explicit enough. What do you think @annezazu? cc @WordPress/gutenberg-design |
ntsekouras
force-pushed
the
update/clear-customizations-copy-for-templates
branch
from
f1f98fd to
1012ab9
Compare
@jameskoster which button is the main one? 😄 |
|
@ntsekouras sorry, I meant that in all cases the button should read:
But that the second line may not be necessary either way. Keen to hear thoughts from others on that. |
|
Testing using the Gutenberg PR plugin build. Before: "Restore template to default state" After: "Use the template as supplied by the theme" (Should include . punctuation.) What about something like: |
ntsekouras
force-pushed
the
update/clear-customizations-copy-for-templates
branch
from
1012ab9 to
c3fb788
Compare
I updated with the above. |
ntsekouras
force-pushed
the
update/clear-customizations-copy-for-templates
branch
from
c3fb788 to
8d74904
Compare
jameskoster
approved these changes
Aug 8, 2022
This was referenced Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves: #30773
This PR updates the
clear customizationscopy for templates to revert user changes. Based on these two comments 1, 2: