Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSE] Clarify what is being reverted when clearing template customizations #30773

Closed
annezazu opened this issue Apr 12, 2021 · 3 comments · Fixed by #41765
Closed

[FSE] Clarify what is being reverted when clearing template customizations #30773

annezazu opened this issue Apr 12, 2021 · 3 comments · Fixed by #41765
Labels
Needs Design Feedback Needs general design feedback. [Status] Blocked Used to indicate that a current effort isn't able to move forward [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable

Comments

@annezazu
Copy link
Contributor

What problem does this address?

When reverting a template to the theme default, the initial expectation is that everything you're looking at will reset when, in truth, only parts will. Here's a quick video showing this:

changes.mov

Because it's not clear what's a template vs a template part, this makes for a somewhat confusing experience and came up during recent user testing.

What is your proposed solution?

Perhaps having a block outline of what will be reverted? Or showing what will change using the List View to confirm reverting? I'm not quite sure as this seems like a design problem that falls in line with other related issues around distinguishing types of content.

cc @jameskoster for thoughts here (no rush). Feel free to close out if this is already being worked on!

@annezazu annezazu added Needs Design Feedback Needs general design feedback. [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable [Feature] Full Site Editing labels Apr 12, 2021
@jameskoster
Copy link
Contributor

jameskoster commented Apr 13, 2021

This is a little bit tricky because we need to account for situations where the template parts are customised, but the parent template is not.

I think the clearest way to achieve this would be to list the template parts in the template details popover and provide a revert link there.

We actually have an issue for listing the parts here.

It doesn't feel like a big leap to provide a revert action (and others) via ellipsis menu:

Screenshot 2021-04-13 at 10 20 11

We can potentially re-use this interface in other areas where template parts are listed (List View).

Edit: Adding blocked label (#29147).

@jameskoster jameskoster added the [Status] Blocked Used to indicate that a current effort isn't able to move forward label Apr 13, 2021
@annezazu
Copy link
Contributor Author

Wow! Excellent thinking.

@annezazu
Copy link
Contributor Author

Noting that this can be closed when this is merged: #41765 cc @ntsekouras for awareness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. [Status] Blocked Used to indicate that a current effort isn't able to move forward [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants