Template part selection popover - minor style updates for visiblity. #33733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +757 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
Addison-Stavlo
added
[Block] Template Part
Addison-Stavlo
requested review from
vindl,
jeyip,
mattwiebe,
Copons,
creativecoder,
david-szabo97,
jasmussen and
annezazu
david-szabo97
approved these changes
Jul 30, 2021
I agree.
I think it might be nice to update this component to somewhat match the style of the patterns placeholder setup component. 🤔 However, there were some concerns with that component both in a11y and user perception and discussions about it being moved to a modal or redesigned in other ways... so its probably best to wait for that to settle in a more permanent state before updating this to match it. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to discussion in #29950. This PR adds some minor style changes to make previews more visible in the selection popover. While we may still need to reconsider the selection flow/component in the future, these minor changes should help improve the readability of the current state until a new design is introduced.
Currently on trunk, there are no borders (save hover and focus) to the items or background to the selection, making it difficult to tell where one preview starts and the other begins:
Here we try adding a gray border to allow the previews to stand out together with their title:
How has this been tested?
Test the template part selection component in the site and post editors. This can be accessed from a placeholder block's (insert header, footer, or template part) "Choose existing" option, or the "replace" option in the block toolbar of an existing template part.
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).