-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template Part: Improve template part creation flow #29950
Comments
More thoughts related to this feature :) For creating a new template, the current flow does not make it obvious how to change the name of the untitled template part which feels like a key step to nudge a user to do in order to not end up with a bunch of untitled parts: New.template.naming.flow.movSeparately though, pulling from thoughts from Matias, editing an existing name should not be as prominent. |
+1 for improving the ability to name a new template part. I had to watch the video to find how to do it. |
Additional, related feedback from the sixth call for testing for the FSE Outreach Program:
Once more, having the title/area more "hidden" under Advanced settings proved to be a confusing experience. |
A recent WordPress.com call for testing also surfaced some confusion around the two placeholder buttons: "Choose existing" opens a popover listing both user-created custom template parts, and theme-provided ones. If the theme or a plugin associates patterns to a template part area, those two buttons both prompt to choose an existing "something", and the difference between them is not clear. In order to clarify what I mean here's a very hypothetical example of how those buttons could be labelled:
|
I feel that adding a 3rd button is a bit odd. Since the patterns selector allows you to 'start blank', the bonus button doesn't add any new functionality but puts us in a state where we have 2 buttons for the same action (creating a new template part), alongside 1 button for selecting an existing item. I think one button for each action should be more clear, and keeping 'start blank' from the pattern selector allows for consistency with its implementation in other blocks. I would definitely agree that these 2 buttons should probably be labeled in a way that is more clear to the user. Now that patterns are implemented, reading above it sounds like the other main items to address here are prompting users with a title input on creation and updating the selection UI. |
Interesting Idea! I think the downside here is that it removes the ability to see previews for mobile screen widths. Although perhaps that is not a huge deal, as you noted the previews are small and hard to see as is.
A small improvement prior to a redesign might be adding a gray background and some outline to prevent them from running together as much. 🤔 |
A few smaller PRs that might help: #33733 - Adds some minor borders to the existing selection previews to help make the previews and their titles more clear until we can update this to use a better design in general. #33703 - Adds a title confirmation step when creating a template part through the placeholder. #33783 - Explores updating the button labels and making them slightly more contextual. My hope is that the new copies might make at least slightly more sense to newer users, or at least convey a larger difference between the two actions. On top of this, the creation label is updated if patterns are available for the creation step. |
It would be very helpful when also a template is selected for specific patterns, as some patterns may only work with specific templates. |
What problem does this address?
Pulling in some feedback from the third call for testing as part of the FSE outreach program from @paaljoachim :
Here's a screenshot of the current experience:
Currently, the template parts run together in a way that's hard to distinguish them and they are quite small to view making it hard to see what you might actually be selecting.
What is your proposed solution?
Ideally, for the "New template part" option, patterns or some sort of placeholder option can be better integrated to help users get started. Currently, one just sees this:
For the "Choose Existing" option, an improved preview can be offered similar to what's done when browsing through templates in the navigation sidebar (aka just have the names listed with a pop out of the preview to the right):
The text was updated successfully, but these errors were encountered: