Reset object animation state in a few places #4049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When going offworld. - When moving a droid into a transporter. This prevents a somewhat uncommon case where cyborgs are walking in-place inside menu buttons, for example. Had to issue a `moveReallyStopDroid()` in the embark event cause units still retained speed inside the transporter...
KJeff01
force-pushed
the
stopTheHappyFeet
branch
from
fd934d8
to
8ce4baf
Compare
KJeff01
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a somewhat uncommon case where cyborgs are walking in-place inside menu buttons, for example.
Edit: In addition to resetting the animation state fixing some of this, I also found out that units retained their speed when embarking. Which caused another animation state event reset to fail causing them to walk after placing them in the transporter before lift off.
And, it fixes movement sounds from playing after disembarking units from a transporter too.