Qodana

Samples/add improvements #119

Sign in to view logs

Triggered via pull request January 22, 2024 07:55

jakubuid

synchronize #1275

samples/add_improvements

Status Success

Total duration 8m 37s

Artifacts –

qodana_code_quality.yml

on: pull_request

Annotations

39 warnings and 4 notices

Control flow with empty body: sample/wallet/src/main/kotlin/com/walletconnect/sample/wallet/ui/Web3WalletActivity.kt#L38

'if' has empty body

JUnit malformed declaration: core/android/src/test/java/CacaoTestJvmTest.java#L16

Test class `CacaoTestJvmTest` is not constructable because it is not 'public'

Serializable object must implement 'readResolve': protocol/chat/src/main/kotlin/com/walletconnect/chat/common/exceptions/ChatExceptions.kt#L17

Serializable object must implement 'readResolve'

Serializable object must implement 'readResolve': protocol/auth/src/main/kotlin/com/walletconnect/auth/common/exceptions/Exceptions.kt#L7

Serializable object must implement 'readResolve'

Serializable object must implement 'readResolve': protocol/chat/src/main/kotlin/com/walletconnect/chat/common/exceptions/ChatExceptions.kt#L18

Serializable object must implement 'readResolve'

Serializable object must implement 'readResolve': protocol/chat/src/main/kotlin/com/walletconnect/chat/common/exceptions/ChatExceptions.kt#L11

Serializable object must implement 'readResolve'

Serializable object must implement 'readResolve': protocol/chat/src/main/kotlin/com/walletconnect/chat/common/exceptions/ChatExceptions.kt#L20

Serializable object must implement 'readResolve'

Serializable object must implement 'readResolve': protocol/chat/src/main/kotlin/com/walletconnect/chat/common/exceptions/ChatExceptions.kt#L19

Serializable object must implement 'readResolve'

Serializable object must implement 'readResolve': protocol/chat/src/main/kotlin/com/walletconnect/chat/common/exceptions/ChatExceptions.kt#L10

Serializable object must implement 'readResolve'

Serializable object must implement 'readResolve': protocol/chat/src/main/kotlin/com/walletconnect/chat/common/exceptions/ChatExceptions.kt#L15

Serializable object must implement 'readResolve'

Serializable object must implement 'readResolve': protocol/auth/src/main/kotlin/com/walletconnect/auth/common/exceptions/Exceptions.kt#L8

Serializable object must implement 'readResolve'

Serializable object must implement 'readResolve': product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/domain/model/Exceptions.kt#L5

Serializable object must implement 'readResolve'

Constant conditions: core/android/src/main/kotlin/com/walletconnect/android/internal/common/storage/rpc/JsonRpcHistory.kt#L58

Condition 'record.response == null' is always false

Constant conditions: product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/ui/navigation/account/Navigation.kt#L28

Condition 'it.id == chainId' is always false

Constant conditions: sample/wallet/src/main/kotlin/com/walletconnect/sample/wallet/domain/EthAccountDelegate.kt#L21

Condition 'sharedPreferences.getString(ACCOUNT_TAG, null) != null' is always true

Constant conditions: core/android/src/main/kotlin/com/walletconnect/android/internal/common/storage/rpc/JsonRpcHistory.kt#L63

Condition 'record.response == null' is always false

Constant conditions: product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/ui/Web3ModalSheet.kt#L81

Value of 'this as? ComponentDialog' is always null

Constant conditions: protocol/sign/src/main/kotlin/com/walletconnect/sign/storage/sequence/SessionStorageRepository.kt#L39

Condition 'hasTopic' is always true

Constant conditions: sample/wallet/src/main/kotlin/com/walletconnect/sample/wallet/ui/routes/composable_routes/inbox/discover/DiscoverTab.kt#L178

Condition 'parsedUrl != null' is always true

Constant conditions: sample/common/src/main/kotlin/com/walletconnect/sample/common/ui/ComposeExtensions.kt#L28

'when' branch is never reachable

Constant conditions: core/android/src/main/kotlin/com/walletconnect/android/internal/common/signing/eip1271/EIP1271Verifier.kt#L76

Cast will always fail

Constant conditions: core/modal/src/main/kotlin/com/walletconnect/modal/utils/DeviceUtils.kt#L9

Condition 'LocalConfiguration.current.orientation == Configuration.ORIENTATION_LANDSCAPE' is always false

Constant conditions: sample/wallet/src/main/kotlin/com/walletconnect/sample/wallet/domain/EthAccountDelegate.kt#L21

Condition '(sharedPreferences.getString(ACCOUNT_TAG, null) != null) \&\& (sharedPreferences.getString(PRIVATE_KEY_TAG, null) != null) \&\& (sharedPreferences.getString(PUBLIC_KEY_TAG, null) != null)' is always true

Constant conditions: sample/wallet/src/main/kotlin/com/walletconnect/sample/wallet/domain/EthAccountDelegate.kt#L21

Condition '(sharedPreferences.getString(ACCOUNT_TAG, null) != null) \&\& (sharedPreferences.getString(PRIVATE_KEY_TAG, null) != null)' is always true

Constant conditions: core/android/src/main/kotlin/com/walletconnect/android/internal/common/storage/pairing/PairingStorageRepository.kt#L35

Condition 'pairingQueries.hasTopic(topic = topic.value).executeAsOneOrNull() != null' is always true

Constant conditions: sample/dapp/src/main/kotlin/com/walletconnect/sample/dapp/ui/routes/composable_routes/chain_selection/ChainSelectionRoute.kt#L165

'when' branch is never reachable

Constant conditions: sample/wallet/src/main/kotlin/com/walletconnect/sample/wallet/domain/NotificationHandler.kt#L176

Condition 'parsedUrl == null' is always false

Constant conditions: core/android/src/main/kotlin/com/walletconnect/android/internal/common/storage/rpc/JsonRpcHistory.kt#L67

Condition 'record != null \&\& record.response == null' is always false

Constant conditions: protocol/sign/src/main/kotlin/com/walletconnect/sign/storage/sequence/SessionStorageRepository.kt#L37

Condition 'sessionDaoQueries.hasTopic(topic.value).executeAsOneOrNull() != null' is always true

Constant conditions: product/walletconnectmodal/src/main/kotlin/com/walletconnect/wcmodal/ui/WalletConnectModalSheet.kt#L53

Value of 'dialog as? ComponentDialog' is always null

Constant conditions: sample/wallet/src/main/kotlin/com/walletconnect/sample/wallet/ui/routes/composable_routes/notifications/NotificiationsScreenRoute.kt#L315

Condition 'parsedUrl != null' is always true

Constant conditions: sample/wallet/src/main/kotlin/com/walletconnect/sample/wallet/domain/EthAccountDelegate.kt#L21

Condition 'sharedPreferences.getString(PRIVATE_KEY_TAG, null) != null' is always true when reached

Constant conditions: sample/wallet/src/main/kotlin/com/walletconnect/sample/wallet/domain/EthAccountDelegate.kt#L21

Condition 'sharedPreferences.getString(PUBLIC_KEY_TAG, null) != null' is always true when reached

Constant conditions: core/android/src/main/kotlin/com/walletconnect/android/internal/common/storage/metadata/MetadataStorageRepository.kt#L41

Condition 'metaDataQueries.getIdByTopicAndType(topic.value, type).executeAsOneOrNull() != null' is always true

Constant conditions: core/android/src/main/kotlin/com/walletconnect/android/internal/common/storage/rpc/JsonRpcHistory.kt#L30

Condition 'record != null' is always true

Constant conditions: sample/dapp/src/main/kotlin/com/walletconnect/sample/dapp/ui/routes/composable_routes/chain_selection/ChainSelectionRoute.kt#L166

'when' branch is never reachable

Constant conditions: sample/wallet/src/main/kotlin/com/walletconnect/sample/wallet/ui/Web3WalletActivity.kt#L139

Condition 'ContextCompat.checkSelfPermission(this, android.Manifest.permission.POST_NOTIFICATIONS) == PackageManager.PERMISSION_GRANTED' is always false

Constant conditions: core/android/src/main/kotlin/com/walletconnect/android/internal/common/storage/rpc/JsonRpcHistory.kt#L67

Condition 'record != null' is always true

Constant conditions: core/android/src/main/kotlin/com/walletconnect/android/internal/common/storage/rpc/JsonRpcHistory.kt#L67

Condition 'record.response == null' is always false when reached

Argument could be converted to 'Set' to improve performance: sample/wallet/src/main/kotlin/com/walletconnect/sample/wallet/domain/NotificationHandler.kt#L105

The argument can be converted to 'Set' to improve performance

Constant conditions: core/android/src/main/kotlin/com/walletconnect/android/internal/common/adapter/JsonRpcResultAdapter.kt#L105

Value of 'jsonrpc' is always null

Constant conditions: product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/ui/Web3ModalSheet.kt#L81

Value of '(this as? ComponentDialog)?.onBackPressedDispatcher' is always null

Constant conditions: product/walletconnectmodal/src/main/kotlin/com/walletconnect/wcmodal/ui/WalletConnectModalSheet.kt#L53

Value of '(dialog as? ComponentDialog)?.onBackPressedDispatcher' is always null