Samples/add improvements #1275

jakubuid · 2024-01-10T07:43:39Z

Fix session request adapter to parse the expiry field
Add better checks for session request expiry
Add expiry for session proposals
Add extended logging for all requests and events
Expose new callbacks to SignInterface:
- onProposalExpired(proposal: Sign.Model.ExpiredProposal)
- onRequestExpired(request: Sign.Model.ExpiredRequest)
Add new callbacks to PairingInterface:
- onPairingExpired(expiredPairing: Core.Model.ExpiredPairing)
- onPairingState(pairingState: Core.Model.PairingState)
Add loaders to user action buttons
Add 10s timeout for Relay ACK publish method
Add missing try and catch blocks
Add connection is restore banner
Add missing loaders to samples

… loaders for emit

github-actions · 2024-01-10T07:59:34Z

Qodana Community for Android

43 new problems were found

Inspection name	Severity	Problems
`Constant conditions`	🔶 Warning	27
`Serializable object must implement 'readResolve'`	🔶 Warning	10
`Control flow with empty body`	🔶 Warning	1
`JUnit malformed declaration`	🔶 Warning	1
`Constant conditions`	◽️ Notice	3
`Argument could be converted to 'Set' to improve performance`	◽️ Notice	1

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

Register at Qodana Cloud and configure the action
Use GitHub Code Scanning with Qodana
Host Qodana report at GitHub Pages
Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true

Contact Qodana team

Contact us at [email protected]

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

…d primitives

github-actions · 2024-01-11T13:57:36Z

Qodana Community for Android

52 new problems were found

Inspection name	Severity	Problems
`Constant conditions`	🔶 Warning	37
`Serializable object must implement 'readResolve'`	🔶 Warning	10
`Control flow with empty body`	🔶 Warning	1
`JUnit malformed declaration`	🔶 Warning	1
`Constant conditions`	◽️ Notice	2
`Argument could be converted to 'Set' to improve performance`	◽️ Notice	1

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

Register at Qodana Cloud and configure the action
Use GitHub Code Scanning with Qodana
Host Qodana report at GitHub Pages
Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true

Contact Qodana team

Contact us at [email protected]

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

...c/main/kotlin/com/walletconnect/android/internal/common/json_rpc/domain/JsonRpcInteractor.kt

core/android/src/main/kotlin/com/walletconnect/android/pairing/handler/PairingController.kt

.../kotlin/com/walletconnect/android/internal/common/exception/CommonWalletConnectExceptions.kt

core/android/src/main/kotlin/com/walletconnect/android/pairing/engine/domain/PairingEngine.kt

product/web3modal/src/main/kotlin/com/walletconnect/web3/modal/client/Web3Modal.kt

core/android/src/main/kotlin/com/walletconnect/android/pairing/model/PairingExpiration.kt

…nV2 into samples/add_improvements

…nV2 into samples/add_improvements # Conflicts: # sample/wallet/src/main/kotlin/com/walletconnect/sample/wallet/ui/routes/composable_routes/connections/ConnectionsRoute.kt

Elyniss

LGTM. Please make smaller PRs next time, tho

…nV2 into samples/add_improvements

jakubuid added 15 commits January 8, 2024 14:54

Add loaders for user action when responding proposal and request. Add…

8d07f80

… loaders for emit

Add loaders for wallet disconnect

6e5d491

Add session update

9123669

Add connection is ok banner

225eb8c

Add loaders for proposal expiry and session updated

32895d9

Pairing expiry watcher

65e710b

Loader for dapp disconnect

3074aa6

Loader for dapp ping

daf22f8

Add indicator that connection is ok

7e179c3

Add request loaders to dapp

9c6bc5f

Fix deep linking schema issue

c4fda14

Add proposal loader dapp

8656a9c

Add missing try and catch blocks

102590f

Handle inactive pairing expiry

f9ac851

Add publish ack timeout

9ea132c

jakubuid added 4 commits January 10, 2024 12:58

Define 5mins request expiry when user doesn't set

ef10242

Handle expired proposal

2991b27

Handle expired proposal on dapp

c022d1f

Fix parsing expiry for session request. Add request expire watcher an…

3f1812d

…d primitives

jakubuid added 9 commits January 11, 2024 17:14

Dapp - check on any pending proposals and show spinner

b9ca29c

Clean up

18f8802

Improve expiry checks

af3c393

Return pairing on expired instead of topic

7e81b9c

Improve connect method

784fa7f

Fix sign unit tests

c92312c

Fix sign integration tests

58e754b

Fix core tests

b1f7f5d

Handle isLoading state in Wallet

203d7bc

jakubuid added 6 commits January 17, 2024 10:16

Sign tests fixing

4e023e4

Increase min value for request expiry

e83394c

Fix validator testing

369d501

Add default expiry in migration

e9f1666

Fix sign database migration

6b655fc

Fix sign database migration

53af9b5

Elyniss reviewed Jan 17, 2024

View reviewed changes

jakubuid added 4 commits January 18, 2024 11:07

Update account id

61c9609

Add new expiryTimestamp field

b07b817

Change setting request expiry on dapp

196661c

Fix handling session requests in sample

12c98b9

Talhaali00 reviewed Jan 22, 2024

View reviewed changes

jakubuid added 4 commits January 22, 2024 08:55

Add expiryTimestamp to pairing uri

d98bc40

Fixing tests

0541bcc

Fix sign tests

436aa0c

Clean up

de816ba

Elyniss reviewed Jan 22, 2024

View reviewed changes

core/android/src/main/kotlin/com/walletconnect/android/pairing/model/PairingExpiration.kt Outdated Show resolved Hide resolved

kacperoak mentioned this pull request Jan 22, 2024

[SAMPLES/W3W] Add hardcoded samples and handling URI from modals in W3W #1279

Merged

jakubuid added 6 commits January 23, 2024 12:31

Merge branch 'develop' of github.com:WalletConnect/WalletConnectKotli…

697b1ad

…nV2 into samples/add_improvements

Merge branch 'develop' of github.com:WalletConnect/WalletConnectKotli…

1411b94

…nV2 into samples/add_improvements # Conflicts: # sample/wallet/src/main/kotlin/com/walletconnect/sample/wallet/ui/routes/composable_routes/connections/ConnectionsRoute.kt

Show snack bar when responding to proposal and request

f05473b

Change Time names

5d54387

Change Expiration names

8f0f707

Address PR comments

2261e99

Elyniss approved these changes Jan 24, 2024

View reviewed changes

jakubuid added 2 commits January 24, 2024 16:03

Decrease snackbar time

a59f878

Merge branch 'develop' of github.com:WalletConnect/WalletConnectKotli…

c7c850e

…nV2 into samples/add_improvements

kacperoak approved these changes Jan 24, 2024

View reviewed changes

jakubuid merged commit 362ff73 into develop Jan 24, 2024
15 checks passed

jakubuid deleted the samples/add_improvements branch January 24, 2024 16:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Samples/add improvements #1275

Samples/add improvements #1275

jakubuid commented Jan 10, 2024 •

edited

Loading

github-actions bot commented Jan 10, 2024 •

edited

Loading

github-actions bot commented Jan 11, 2024 •

edited

Loading

Elyniss left a comment

Samples/add improvements #1275

Samples/add improvements #1275

Conversation

jakubuid commented Jan 10, 2024 • edited Loading

github-actions bot commented Jan 10, 2024 • edited Loading

Qodana Community for Android

github-actions bot commented Jan 11, 2024 • edited Loading

Qodana Community for Android

Elyniss left a comment

Choose a reason for hiding this comment

jakubuid commented Jan 10, 2024 •

edited

Loading

github-actions bot commented Jan 10, 2024 •

edited

Loading

github-actions bot commented Jan 11, 2024 •

edited

Loading