Skip to content

fix(docs openinula-vchart react-vchart): correct typo in 'vchartConstrouctor' prop name #3942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

drunksweet
Copy link

@drunksweet drunksweet commented May 7, 2025

fix(docs openinula-vchart react-vchart): correct typo in 'vchartConstrouctor' prop name

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Release
  • Site / documentation update
  • Demo update
  • Workflow
  • Other (about what?)

🔗 Related issue link

#3541
fix #3541

🔗 Related PR link

🐞 Bugserver case id

💡 Background and solution

It's just a misspelled variable name.
Replace all the vchartConstrouctor to vchartConstructor.It doesn't impact the functionality.

📝 Changelog

Replace all the vchartConstrouctor to vchartConstructor.It doesn't impact the functionality.

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@drunksweet drunksweet changed the title fix(docs openinula-vchart react-vchart): correct typo in 'vchartConst… fix(docs openinula-vchart react-vchart): correct typo in 'vchartConstrouctor' prop name May 7, 2025
修复 openinula-vachart 和 react-vachart 中 vchartConstructor 与 vchartConstrouctor 两种属性名的兼容性问题。

新增 @deprecated 注释,引导用户使用新的、正确拼写的属性名。
@xile611
Copy link
Contributor

xile611 commented May 14, 2025

@drunksweet 代码已经没问题了,合并前,需要本地跑一下 rush change 来生成一下日志,在发布的时候会读取这个日志,写入到发布日志中

@github-actions github-actions bot added the chore label May 14, 2025
@drunksweet
Copy link
Author

@drunksweet 代码已经没问题了,合并前,需要本地跑一下 rush change 来生成一下日志,在发布的时候会读取这个日志,写入到发布日志中

已添加 changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Typo]The name of vchartConstrouctor prop in VChartSimple maybe a typo mistake
2 participants