Skip to content

Commit 4864e1d

Browse files
committed
fix: 修复 vchartConstructor 拼写错误的兼容问题
修复 openinula-vachart 和 react-vachart 中 vchartConstructor 与 vchartConstrouctor 两种属性名的兼容性问题。 新增 @deprecated 注释,引导用户使用新的、正确拼写的属性名。
1 parent dbca502 commit 4864e1d

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

packages/openinula-vchart/src/charts/BaseChart.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ export interface BaseChartProps
3838
ChartLifeCycleEventProps,
3939
IReactTooltipProps {
4040
vchartConstructor?: IVChartConstructor;
41+
/** @deprecated 请使用 vchartConstructor */
42+
vchartConstrouctor?: IVChartConstructor;
4143
type?: string;
4244
/** 上层container */
4345
container?: HTMLDivElement;
@@ -74,6 +76,7 @@ const notSpecKeys = [
7476
...REACT_PRIVATE_PROPS,
7577
...CHART_EVENTS_KEYS,
7678
'vchartConstructor',
79+
'vchartConstrouctor',
7780
'useSyncRender',
7881
'skipFunctionDiff',
7982
'onError',
@@ -152,7 +155,7 @@ const BaseChart: React.FC<Props> = React.forwardRef((props, ref) => {
152155
};
153156

154157
const createChart = (props: Props) => {
155-
const cs = new props.vchartConstructor(parseSpec(props), {
158+
const cs = new (props.vchartConstructor ?? (props as any).vchartConstrouctor)(parseSpec(props), {
156159
...props.options,
157160
onError: props.onError,
158161
autoFit: true,

packages/react-vchart/src/charts/BaseChart.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ export interface BaseChartProps
4747
ChartLifeCycleEventProps,
4848
IReactTooltipProps {
4949
vchartConstructor?: IVChartConstructor;
50+
/** @deprecated 请使用 vchartConstructor */
51+
vchartConstrouctor?: IVChartConstructor;
5052
type?: string;
5153
/** 上层container */
5254
container?: HTMLDivElement;
@@ -88,6 +90,7 @@ const notSpecKeys = [
8890
...REACT_PRIVATE_PROPS,
8991
...CHART_EVENTS_KEYS,
9092
'vchartConstructor',
93+
'vchartConstrouctor',
9194
'useSyncRender',
9295
'skipFunctionDiff',
9396
'onError',
@@ -178,7 +181,7 @@ const BaseChart: React.FC<Props> = React.forwardRef((props, ref) => {
178181
};
179182

180183
const createChart = (props: Props) => {
181-
const cs = new props.vchartConstructor(parseSpec(props), {
184+
const cs = new (props.vchartConstructor ?? (props as any).vchartConstrouctor)(parseSpec(props), {
182185
...props.options,
183186
onError: props.onError,
184187
autoFit: true,

0 commit comments

Comments
 (0)