Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added ability to override default headless service #1975

Merged
merged 1 commit into from
Feb 5, 2025
Merged

added ability to override default headless service #1975

merged 1 commit into from
Feb 5, 2025

Conversation

AndrewChubatiuk
Copy link
Collaborator

@github-actions github-actions bot added cluster vmcluster helm chart related issue single VictoriaMetrics Single node helm chart related issue logs metrics labels Feb 5, 2025
f41gh7
f41gh7 previously approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewChubatiuk AndrewChubatiuk force-pushed the added-ability-to-override-headless-service branch from c600fa7 to 9ef1861 Compare February 5, 2025 21:12
@github-actions github-actions bot added k8s-stack k8s-stack helm chart related issue common labels Feb 5, 2025
@AndrewChubatiuk AndrewChubatiuk force-pushed the added-ability-to-override-headless-service branch from 9ef1861 to 808dd3c Compare February 5, 2025 22:02
@github-actions github-actions bot added the agent vmagent helm chart related issue label Feb 5, 2025
@AndrewChubatiuk AndrewChubatiuk merged commit c2aa748 into master Feb 5, 2025
17 checks passed
@AndrewChubatiuk AndrewChubatiuk deleted the added-ability-to-override-headless-service branch February 5, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f41gh7 f41gh7 f41gh7 left review comments

@zekker6 zekker6 Awaiting requested review from zekker6 zekker6 is a code owner

@Haleygo Haleygo Awaiting requested review from Haleygo Haleygo is a code owner

Assignees
No one assigned
Labels
agent vmagent helm chart related issue cluster vmcluster helm chart related issue common k8s-stack k8s-stack helm chart related issue logs metrics single VictoriaMetrics Single node helm chart related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewChubatiuk @f41gh7 @victoriametrics-bot