added ability to override default headless service

Author: AndrewChubatiuk

charts/victoria-logs-single/CHANGELOG.md

@@ -1,5 +1,6 @@
 ## Next release
 
+- added ability to override default headless service .Values.server.service.clusterIP with empty value
 - vector chart 0.37.x -> 0.40.x
 
 ## 0.8.14

charts/victoria-logs-single/README.md

@@ -910,7 +910,7 @@ readOnlyRootFilesystem: true
       <td>server.service.clusterIP</td>
       <td>string</td>
       <td><pre class="helm-vars-default-value language-yaml" lang="">
-<code class="language-yaml">""
+<code class="language-yaml">None
 </code>
 </pre>
 </td>

charts/victoria-logs-single/templates/server-service.yaml

@@ -20,12 +20,11 @@ spec:
   {{- end }}
   type: {{ $type }}
   {{- $clusterIP := $service.clusterIP }}
-  {{- if and (not $clusterIP) (eq $type "ClusterIP") $app.statefulSet.enabled }}
-    {{- $clusterIP = "None" }}
-  {{- end }}
-  {{- with $clusterIP }}
+  {{- if eq $type "ClusterIP" }}
+  {{- with $service.clusterIP }}
   clusterIP: {{ . }}
   {{- end }}
+  {{- end }}
   {{- with $service.externalIPs }}
   externalIPs: {{ toYaml . | nindent 4 }}
   {{- end }}

charts/victoria-logs-single/values.yaml

@@ -252,7 +252,7 @@ server:
     # -- Service labels
     labels: {}
     # -- Service ClusterIP
-    clusterIP: ""
+    clusterIP: None
     # -- Service external IPs. Details are [here]( https://kubernetes.io/docs/user-guide/services/#external-ips)
     externalIPs: []
     # -- Service load balancer IP

charts/victoria-metrics-cluster/CHANGELOG.md

@@ -1,6 +1,6 @@
 ## Next release
 
-- TODO
+- added ability to override default headless service .Values.vmselect.service.clusterIP with empty value
 
 ## 0.17.4
 

charts/victoria-metrics-cluster/README.md

@@ -200,6 +200,17 @@ Change the values according to the need of the environment in ``victoria-metrics
 </pre>
 </td>
       <td><p>Image registry, that can be shared across multiple helm charts</p>
+</td>
+    </tr>
+    <tr>
+      <td>global.image.vm.tag</td>
+      <td>string</td>
+      <td><pre class="helm-vars-default-value language-yaml" lang="">
+<code class="language-yaml">""
+</code>
+</pre>
+</td>
+      <td><p>Image tag for all vm charts</p>
 </td>
     </tr>
     <tr>
@@ -2632,7 +2643,7 @@ timeoutSeconds: 5
       <td>vmselect.service.clusterIP</td>
       <td>string</td>
       <td><pre class="helm-vars-default-value language-yaml" lang="">
-<code class="language-yaml">""
+<code class="language-yaml">None
 </code>
 </pre>
 </td>

charts/victoria-metrics-cluster/templates/service.yaml

@@ -22,12 +22,10 @@ spec:
     {{- $type = "ClusterIP" }}
   {{- end }}
   type: {{ $type }}
-  {{- $clusterIP := $service.clusterIP }}
-  {{- if and (not $clusterIP) (eq $type "ClusterIP") ($app.statefulSet).enabled }}
-    {{- $clusterIP = "None" }}
+  {{- if eq $type "ClusterIP" }}
+  {{- with $service.clusterIP }}
+  clusterIP: {{. }}
   {{- end }}
-  {{- with $clusterIP }}
-  clusterIP: {{ . }}
   {{- end }}
   {{- with $service.externalIPs }}
   externalIPs: {{ toYaml . | nindent 4 }}

charts/victoria-metrics-cluster/tests/__snapshot__/service_test.yaml.snap

@@ -61,6 +61,7 @@ service should match snapshot:
       name: RELEASE-NAME-victoria-metrics-cluster-vmselect
       namespace: NAMESPACE
     spec:
+      clusterIP: None
       ports:
         - name: http
           port: 8481
@@ -170,6 +171,7 @@ service should match snapshot with fullnameOverride and extraLabels:
       name: vmselect-node
       namespace: NAMESPACE
     spec:
+      clusterIP: None
       ports:
         - name: http
           port: 8481

charts/victoria-metrics-cluster/values.yaml

@@ -7,6 +7,9 @@ global:
   image:
     # -- Image registry, that can be shared across multiple helm charts
     registry: ""
+    vm:
+      # -- Image tag for all vm charts
+      tag: ""
   # -- Openshift security context compatibility configuration
   compatibility:
     openshift:
@@ -220,7 +223,7 @@ vmselect:
     # -- Service labels
     labels: {}
     # -- Service ClusterIP
-    clusterIP: ""
+    clusterIP: None
     # -- Service external IPs. Details are [here](https://kubernetes.io/docs/user-guide/services/#external-ips)
     externalIPs: []
     # -- Extra service ports

charts/victoria-metrics-common/CHANGELOG.md

@@ -2,7 +2,7 @@
 
 ## Next release
 
-- TODO
+- Support `.Values.global.image.vm.tag` property to set tag for all VM images globally
 
 ## 0.0.38