Skip to content

chore [Nex-57]: remove calling wrap_error for HTTPException #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

yuming-long
Copy link
Contributor

we should not add each case for different HTTP status code -> should just raise one when we see one

wrap_error should only be called for Exception

@yuming-long yuming-long changed the title chore: remove calling wrap_error for HTTPException chore [Nex-57]: remove calling wrap_error for HTTPException Jun 30, 2025
Copy link

@ds-filipknefel ds-filipknefel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll close mine and we can merge this, let's handle the HTTPExeption in wrap function though it can lead to unexpected behavior if someone passes is as argument and we don't really indicate they shouldn't.

@yuming-long yuming-long merged commit 61a29e7 into main Jun 30, 2025
9 checks passed
@yuming-long yuming-long deleted the yuming/nex-57-readtimeout-did-not-raised-correctly-for-partitioner-and branch June 30, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants