feat: propagate HTTPExceptions in /invoke
#54
Conversation
| @@ -45,15 +41,10 @@ class CatchAllError(BaseError): | |||
|
|
|||
|
|
|||
| def wrap_error(e: Exception) -> HTTPException: | |||
| if isinstance(e, ingest_errors.UserAuthError): | |||
| if isinstance(e, HTTPException): | |||
There was a problem hiding this comment.
btw this is where its called for HTTPException
https://github.com/Unstructured-IO/unstructured-platform-plugins/blob/main/unstructured_platform_plugins/etl_uvicorn/api_generator.py#L219
do you think we can also move status_code=wrap_error(exc).status_code, -> status_code=exc.status_code?
There was a problem hiding this comment.
tbh we don't need a case for HTTPException if we don't call this func for it...
There was a problem hiding this comment.
i created a dup pr #55
for my ticket 😬
There was a problem hiding this comment.
Yeah, I don't think we need to call the wrap in that case.
I think I'd leave the case for HTTPException though, it makes sense that HTTPException maps onto itself and there's no good way to indicate you shouldn't feed HTTPExceptions into it.
There was a problem hiding this comment.
hmm no i don't get it tho
if you call wrap_error(e = HTTPException) you would get a CatchAllError(e) which will convert you status code to 512
which is the case for my ticket we see a lot of 512 with emppty detail
Some HTTP exceptions are assigned custom classes but for an uncovered HTTP code we should propagate the exception.