chore: editor namespace auto upgrade - #4142
Conversation
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Harness Review
The relocation metadata covers the unconditional public editor API, but the new validation harness has a configuration-specific coverage gap and cannot be run reliably from paths containing spaces.
Reviewed commit dcf9a26
🤖 Helpful? 👍/👎
Removed obsolete custom property drawer for NetworkObject.OwnershipStatus.
…com/Unity-Technologies/com.unity.netcode.gameobjects into chore/editor-namespace-auto-upgrade
| @@ -0,0 +1,121 @@ | |||
| # API updater upgrade-path project | |||
There was a problem hiding this comment.
This README has too much info. The README from this project doesn't need info on how the upgrade was implemented, it just needs info on how it works.
If you want this project to be used also for future upgrades then this README shouldn't have any references to the 2.x -> 3.x upgrade specifically, otherwise future us might think we can pull this project out once that upgrade is released.
There was a problem hiding this comment.
This project and the tests associated with it will not be pertinent once v2.x.x becomes deprecated.
But I can remove the extra info...leaving it only provides the context as to why it is there in the first place.
There was a problem hiding this comment.
This should be much more straight forward now.
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop-3.x.x #4142 +/- ##
=================================================
+ Coverage 78.00% 78.01% +0.01%
=================================================
Files 153 153
Lines 26260 26260
=================================================
+ Hits 20483 20486 +3
+ Misses 5777 5774 -3
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes
|
|
/ci apiupdater |
|
/ci apiupdater |
|
/ci apiupdater |
|
/ci apiupdater |
| print(f"Project: {PROJECT_PATH}") | ||
|
|
||
| backup_dir = tempfile.mkdtemp(prefix='ngo-apiupdater-') | ||
| copy_flat(SOURCE_DIR, backup_dir) |
There was a problem hiding this comment.
After a documented run with --keep-updated-sources, this directory contains only the rewritten 3.x sources. A subsequent invocation backs up those already-updated files here, invokes Unity with no legacy references to migrate, and assert_rewritten() returns PASS because it only requires new names to be present and old names absent. That makes a repeat of the documented inspection command a false-positive upgrade validation. Validate that the pre-run fixtures contain the expected legacy references (or restore a canonical legacy fixture before each run), even when keeping the output.
🤖 Helpful? 👍/👎
|
/ci apiupdater |
2 participants
Purpose of this PR
This PR handles the auto-upgrade namespace change from Unity.Netcode.Editor to Unity.Netcode.GameObjects.Editor.
It also includes a job that can be manually triggered to validate the auto-upgrade or the job itself could be added to nightly or the like.
Jira ticket
MTT-15570
Changelog
NA
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Up-port
None
Backports
None