Skip to content

fix: PVP issues related to assemblies, file names, and other non-xml-API related #3444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 12 commits into
base: develop-2.0.0
Choose a base branch
from
Draft

fix: PVP issues related to assemblies, file names, and other non-xml-API related #3444

wants to merge 12 commits into from

Conversation

NoelStephensUnity
Copy link
Collaborator

Do Not Merge Until...

  • Referenced assemblies are checked for tools integration project (if we keep this).
  • If we don't keep tools integration project, make sure this PR includes:
    • The removal of the tools integration tests project.
    • The removal of the project in YAML.
  • PR-720 is passing and all adjustments needed are complete.

PVP Fixes

This includes some (not all) fixes for:
PVP-133-2
PVP-130-2

Depends upon PR-720

Changelog

NA

Testing and Documentation

  • Tools tests have been migrated to multiplayer tools repository.
  • No documentation changes or additions were necessary.

Backport

A backport similar to this will be required but will not be these specific changes.

@NoelStephensUnity
fix
7ac70f5 
This includes some (not all) fixes for:
PVP-133-2
PVP-130-2
@NoelStephensUnity
update: pvp 124-2
ea7f253 
Removing space at end of line.
Minor private comment fixes.
@NoelStephensUnity
update
60a9e41 
Updating manifest to do a test run with the modified tools repository/
@NoelStephensUnity
update
eaed659 
Removing all of the tools related tests from NGO package.
@NoelStephensUnity
update
fe27184 
Removing the scene event tests.
@NoelStephensUnity
update
904c763 
Missed one internal visibility even though it doesn't impact anything (yet).
@NoelStephensUnity
fix
985e304 
Re-base merge fix.
@NoelStephensUnity
update
d47fe47 
Adding the test project's tests assembly to internals.
@NoelStephensUnity NoelStephensUnity mentioned this pull request May 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmandM EmandM Awaiting requested review from EmandM EmandM will be requested when the pull request is marked ready for review EmandM is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NoelStephensUnity