Skip to content

fix: disabling Physics2D or Physics compilation errors #3422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: develop-2.0.0
Choose a base branch
from

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Apr 24, 2025

This PR resolves the issue where disabling the physics or physics2d package module while leaving the other still enabled could cause compilation issues.

Changelog

  • Fixed: Issue where disabling the physics or physics2D package modules could result in a compilation error.

Testing and Documentation

  • No tests have been added. (has to be manually tested)
  • No documentation changes or additions were necessary.

Backport

No backport is needed since this is a v2.x specific issue.

First pass separation of Physics2D and Physics rigid body references.
Missed two spots.
Found a few more places where we want to also check for COM_UNITY_MODULES_PHYSICS2D.
Adding changelog entry.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review May 19, 2025 18:23
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner May 19, 2025 18:23
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) May 22, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants