Skip to content

[MTT-11940] Fix: Rate Limited exceeded bug (same profile used join session via name) #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[MTT-11940] Fix: Rate Limited exceeded bug (same profile used join session via name) #909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
781c834
fix: added error message for uncaught same profile already in session…
Elfi0Kuhndorf Apr 30, 2025
99e6504
update to CHANGELOG
Elfi0Kuhndorf Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Assets/Scripts/Gameplay/UI/UnityServicesUIHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@ void HandleSessionError(UnityServiceErrorMessage error)
break;
}
}
else
{
PopupManager.ShowPopupPanel("Unknown Issue", error.Message);
}
}

void OnDestroy()
Expand Down
5 changes: 5 additions & 0 deletions Assets/Scripts/UnityServices/Sessions/MultiplayerServicesFacade.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,11 @@ public void EndTracking()

try
{
var joinedSessionList = await MultiplayerService.Instance.GetJoinedSessionIdsAsync();
if (joinedSessionList.Contains(sessionName))
{
throw new Exception($"Already joined session {sessionName}") ;
}
var session = await m_MultiplayerServicesInterface.JoinSessionById(sessionName, m_LocalUser.GetDataForUnityServices());
return (true, session);
}
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ Additional documentation and release notes are available at [Multiplayer Documen
* Fixed error logged when unsubscribing from Session events when removed from a Session (#905)
* Fixed error logged when attempting to despawn an already despawned LoadingProgressTracker NetworkObject (#907)
* Fixed error logged when a Melee action was acted on a Breakable object (#908)
* Fixed rate limit exceeded error popping up when trying to join session with already used profile (#909)

## [2.5.0] - 2024-04-18

Expand Down